Re: [PATCH v5 06/15] remote-testgit: get rid of non-local functionality

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Nov 21, 2012, 23:44 UTC
Message-ID: <CAMP44s1CH4Ay=Z5oq18UXwPk3iDH1V2uzA_C0wNDw6d87JV-vA@mail.gmail.com>
In-Reply-To: <7v624y3h0q.fsf@alter.siamese.dyndns.org>

On Wed, Nov 21, 2012 at 7:26 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 27 quoted lines

> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> This only makes sense for the python remote helpers framework.
>
> A better explanation is sorely needed for this.  If the test were
> feeding python snippet to be sourced by python remote helper to be
> tested, the new remote-testgit.bash would not have any hope (nor
> need) to grok it, and "this only makes sense for python" makes
> perfect sense and clear enough, but that is not the case.
>
> If the justification were like this:
>
>     remote-testgit: remove non-local tests
>
>     The simplified remote-testgit does not talk with any remote
>     repository and incapable of running non-local tests.  Remove
>     them.
>
> I would understand it, and I wouldn't say it is a regression in the
> test not to test "non-local", as that is not essential aspect of
> these tests (we are only interested in testing the object/ref
> transfer over remote-helper interface and do not care what the
> "other side" really is).
>
> But I am not quite sure what you really mean by "non-local"
> functionality in the first place.  The original test weren't opening
> network port to emulate multi-host remote transfer, were it?

No, that's not it at all.

By local, I mean 'file:///home/user/foo', by remote, I mean 'http://user.org/foo'. How each of these URLs is handled is entirely up to the remote helper.

bzr for example doesn't need any change at all, the same API works on both cases. hg OTOH has different APIs, so the code needs a local clone to do most operations. The python remote helper framework has APIs to make it easier to implement the local clone functionality (for the remote helpers that need it).

This has absolutely nothing to do with with remote helpers, this is 100% a python remote helper feature. So we don't need those tests here, they belong in git-remote-testpy.

Cheers.

-- 
Felipe Contreras