Re: [PATCH v5 05/15] Add new simplified git-remote-testgit

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 21, 2012, 18:26 UTC
Message-ID: <7vboeq3h0t.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1352642392-28387-6-git-send-email-felipe.contreras@gmail.com>

Felipe Contreras <felipe.contreras@gmail.com> writes:

Show 5 quoted lines

> It's way simpler. It exerceises the same features of remote helpers.
> It's easy to read and understand. It doesn't depend on python.
>
> It does _not_ exercise the python remote helper framework; there's
> another tool and another test for that.

You mention why you _think_ it is better, and what it is _not_, but with your excitement, end up failing to mention what it is. I'll try to reword the commit with this sentence:

	This script is to test the remote-helper interface.

somewhere. Please check what I'll push out on 'pu' after I'm done for the day (probably in 8 hours).

>  git-remote-testgit                   |  62 ++++++++++++++++
>  t/t5801-remote-helpers.sh            | 139 +++++++++++++++++++++++++++++++++++
>  3 files changed, 202 insertions(+), 1 deletion(-)
>  create mode 100755 git-remote-testgit

I hinted at this in an earlier message, but creating this file as a tracked file at this point in the history is a bit irritating for bisectability. After you build and test an earlier commit, this path is a generated and ignored, and then checking out this commit or a later one will fail without "make clean". It is only a minor irritation, but still noticeable.

Thanks.