Re: [PATCH 1/9] remote-bzr: trivial cleanups

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Apr 25, 2013, 19:33 UTC
Message-ID: <CAMP44s1hw_Rq2=N+emKWMzKyVxO5FVLM_H9WJ3x5awte-siw=A@mail.gmail.com>
In-Reply-To: <5179842D.6060500@gmail.com>

On Thu, Apr 25, 2013 at 2:29 PM, Stefano Lattarini <stefano.lattarini@gmail.com> wrote:

> On 04/25/2013 08:19 PM, Ramkumar Ramachandra wrote:

Show 12 quoted lines

>>> @@ -521,7 +521,7 @@ def c_style_unescape(string):
>>>      return string
>>>
>>>  def parse_commit(parser):
>>> -    global marks, blob_marks, bmarks, parsed_refs
>>> +    global marks, blob_marks, parsed_refs
>>
>> How is this trivial?  You just removed one argument.
>>
> Maybe bmarks was no longer used there as a global variable
> (left-over from previous patches?), so there is no longer any
> need to declare it global.

Even more, it never was used, it was a mistake carried when copying this method from remote-hg; we don't have bookmarks in bazaar. And bmarks wasn't even used in this method in remote-hg either =/

But it would be obvious that it was not used once one ran the tests and they passed, which they do.

Cheers.

-- 
Felipe Contreras