Re: [PATCH 1/9] remote-bzr: trivial cleanups
- From
Ramkumar Ramachandra <artagnon@gmail.com>
- Date
- Apr 25, 2013, 18:19 UTC
- Message-ID
- <CALkWK0meg1FgU=-4MFoFGjpDq_oa9XR_+qeiseR0J85mS71dNg@mail.gmail.com>
- In-Reply-To
- <1366888849-19607-2-git-send-email-felipe.contreras@gmail.com>
Felipe Contreras wrote:
Show 10 quoted lines
> diff --git a/contrib/remote-helpers/git-remote-bzr b/contrib/remote-helpers/git-remote-bzr > index aa7bc97..82bf7c7 100755 > --- a/contrib/remote-helpers/git-remote-bzr > +++ b/contrib/remote-helpers/git-remote-bzr > @@ -94,7 +94,7 @@ class Marks: > return self.last_mark > > def is_marked(self, rev): > - return self.marks.has_key(rev) > + return rev in self.marks
Why? Is the new form faster than the older one?
Show 6 quoted lines
> @@ -224,7 +224,7 @@ def export_files(tree, files): > else: > mode = '100644' > > - # is the blog already exported? > + # is the blob already exported?
What is this? Whitespace?
Show 6 quoted lines
> @@ -521,7 +521,7 @@ def c_style_unescape(string): > return string > > def parse_commit(parser): > - global marks, blob_marks, bmarks, parsed_refs > + global marks, blob_marks, parsed_refs
How is this trivial? You just removed one argument.
Show 6 quoted lines
> @@ -555,7 +555,7 @@ def parse_commit(parser):
> mark = int(mark_ref[1:])
> f = { 'mode' : m, 'data' : blob_marks[mark] }
> elif parser.check('D'):
> - t, path = line.split(' ')
> + t, path = line.split(' ', 1)How on earth is this trivial? It changes the entire meaning!
Show 5 quoted lines
> @@ -643,6 +643,7 @@ def do_export(parser): > wt = repo.bzrdir.open_workingtree() > wt.update() > print "ok %s" % ref > +
Whitespace?
I'm outraged by this. What kind of changes are you pushing to remote-hg? A "trivial cleanups" bundling miscellaneous changes, with no commit message? Why don't you just squash everything into one "miscellaneous changes" patch?