Re: [PATCH 1/9] remote-bzr: trivial cleanups

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 25, 2013, 21:37 UTC
Message-ID: <7vwqrq1eco.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CAMP44s1uS23OvsDY+_YOBGMgc9t=FBEV3YvM34M9sLMEF9hnTg@mail.gmail.com>

Felipe Contreras <felipe.contreras@gmail.com> writes:

Show 14 quoted lines

> On Thu, Apr 25, 2013 at 3:30 PM, Thomas Rast <trast@inf.ethz.ch> wrote:
>> Felipe Contreras <felipe.contreras@gmail.com> writes:
>>
>>> But I do not care that much really. The patch is good either way, if
>>> you don't like it, you go ahead and fix it, because I won't. I have
>>> 174 remote-helper related patches in my queue, and nobody benefits
>>> from rambling about a one liner that is obviously correct, not you,
>>> not me, not the users, not the developers.
>>
>> You don't stick to the rules of this project, which have been pointed
>> out already:
>
> The rules of the contrib area are different from the ones of the rest
> of the project.

Yes and no.

A contrib/ material may not be held to the same high standard, but that does not mean a contrib/ area maintainer has a blank check to do anything there.

It would be pretty obvious to people observing what happens in the area after a while, if the quality standard the area maintainer enforces is too out of whack, and at that point the area maintainer deserves to be ridiculed ;-)

> And I don't recall Peff ever doing this "constructive
> fine-let's-do-the-work-for-him" on any contrib/remote-helpers stuff.

I do not think Thomas was talking specific about contrib/ material but your interaction in general with other developers.

Cf. http://thread.gmane.org/gmane.comp.version-control.git/220427/focus=220891

FWIW, I thought "that person was me" response from him was more than reasonable, and I still do.