Re: [PATCH 1/9] remote-bzr: trivial cleanups

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Apr 26, 2013, 19:39 UTC
Message-ID: <CAMP44s0r52L0_r-tQWCkLjOvV7jBghHLqMi6rh_UyChXvx6J1g@mail.gmail.com>
In-Reply-To: <CALkWK0mHCNdr7+QxmmB3jTnWTe8q0_ipXD0=1bKQdpLK07gnAg@mail.gmail.com>

On Fri, Apr 26, 2013 at 1:53 PM, Ramkumar Ramachandra <artagnon@gmail.com> wrote:

Show 17 quoted lines

> Felipe Contreras wrote:
>> What is your objective, do you want to help this project move forward or not?
>
> Forward, please.
>
> I want a solution to this persistent problem of conflict though.  And
> I presented one in my previous email:
>
> Here's my solution to the problem: maintain your project outside
> git.git and merge changes in every couple of months or so with a
> simple email containing a pull URL, addressing Junio.  If Junio trusts
> you enough to put the changes you send into contrib/ after a cursory
> glance, we're done.  Start a separate mailing list for your project/
> accept GitHub pull requests via which contributors can send you
> changes.  No more fuss or drama on the git list about this.  You can
> be as stubborn as you want, and we go back to our lives.  Everyone
> wins.

I already maintain my own clone outside of git.git[1], and I do already accept pull requests[2], and people have sent me patches directly. The stuff I send to the git mailing list is what I think is ready for merging. But there's only so much stuff I can catch.

We all benefit from these patches being reviewed in the git mailing list, nobody has claimed otherwise. You are making the error of assuming that your review was actionable, that I should have done something, fix the commit message I suppose, but I don't think that's important.

In contrast, this is how a constructive, valid and helpful review looks like:

http://article.gmane.org/gmane.comp.version-control.git/220034

Junio caught a problem I didn't see, I accepted the valid feedback, and I resent with a fix. We all benefit from such interactions, both users, and developers. What's wrong with that?

You just got angry that your review didn't turn out to be helpful, is that it? Why do you want to steal helpful review from the users of remote-{bzr,hg}? If that's not the case, please stop doing that. All review is welcome, not all review should be acted upon.

Cheers.

[1] https://github.com/felipec/git [2] https://github.com/felipec/git/pulls?direction=desc&page=1&sort=created&state=closed

-- 
Felipe Contreras