Re: [PATCH] i18n: disable i18n for shell scripts if NO_GETTEXT defined

From: Alex Riesen <raa.lkml@gmail.com>
Date: Jan 18, 2012, 18:57 UTC
Message-ID: <CALxABCadHdvR02Br9e6STy0w+EPoycUKr62RiSUSP_EPF-TH3g@mail.gmail.com>
In-Reply-To: <CACBZZX4TsL-tj04PmUwGNWjXO+JY-8unAv-aRKOGvgB71qdYCg@mail.gmail.com>

On Wed, Jan 18, 2012 at 16:22, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

Show 19 quoted lines

> On Tue, Jan 17, 2012 at 14:42, Alex Riesen <raa.lkml@gmail.com> wrote:
>> Otherwise the i18n is used in the scripts even with NO_GETTEXT set.
>> It is very unexpected.
>
> So the reason it's like that is that I was assuming that gettext.sh
> wouldn't be FUBAR anywhere, but the translations shouldn't kick in
> since we haven't installed them during "make install".
>
> But I wonder if this negatively affects some systems, now we now:
>
>  * Don't use gettext.sh, which means that we're using our fallback
>   shell function instead of the binary gettext(1), which is probably
>   faster.
>
>  * Use our own eval_gettext() instead of using the system one, which
>   uses the GNU binary which is more likely to be in the FS cache
>   already since other programs are probably using it.
>
> Which is why I didn't do something like this to begin with.

Well, if I say NO_GETTEXT, I kind of want none of local gettext, whether it works, or not.