Re: [PATCH] git-sh-i18n: detect and avoid broken gettext(1) implementation

From: Alex Riesen <raa.lkml@gmail.com>
Date: Jan 20, 2012, 20:13 UTC
Message-ID: <CALxABCZJATyVRf9akmfpn3WpJ8Xt80Ky0isFOTwDGpFKvFp3nw@mail.gmail.com>
In-Reply-To: <7vobtydu0o.fsf@alter.siamese.dyndns.org>

On Fri, Jan 20, 2012 at 21:00, Junio C Hamano <gitster@pobox.com> wrote:

Show 11 quoted lines

> IOW, the first step would look like the attached patch, and then we can
> replace the entire "First decide" part if/elif/fi chain with just this:
>
>        # The scheme to use
>        : ${GIT_INTERNAL_GETTEXT_SH_SCHEME:=@@GETTEXT_SH_SCHEME@@}
>
> so that t/lib-gettext.sh can define and export GIT_INTERNAL_GETTEXT_SH to
> always get what it wants to test (fallthrough?). At build time, instead
> of, or in addition to, the $(cmd_munge_script), we could replace the
> single @@GETTEXT_SH_SCHEME@@ token above with whatever scheme we want to
> use to hardcode the decision we make at the compile time.

I can imagine a Solaris system being upgraded to GNU gettext _after_ Git installation. Hardcoding the decision might break git scripts then.