Re: [PATCH 2/2] add a Makefile switch to avoid gettext translation in shell scripts

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jan 23, 2012, 22:40 UTC
Message-ID: <20120123224016.GH20833@burratino>
In-Reply-To: <7vehuq6ote.fsf@alter.siamese.dyndns.org>

Junio C Hamano wrote:

> Jonathan Nieder <jrnieder@gmail.com> writes:

Show 15 quoted lines

>> Nice implementation.  I still don't understand why NO_GETTEXT=YesPlease
>> should not imply this.
>
> Should be easy to do so, like this?
>
> diff --git a/Makefile b/Makefile
> index a782409..c4c1066 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1521,6 +1521,7 @@ ifdef GETTEXT_POISON
>  endif
>  ifdef NO_GETTEXT
>  	BASIC_CFLAGS += -DNO_GETTEXT
> +	USE_GETTEXT_SCHEME = fallthrough
>  endif

Yep, that would make my worries about intuitive behavior evaporate. :) (Maybe "USE_GETTEXT_SCHEME ?= fallthrough" to make it easier to override in config.mak.)

Thanks. I also would not actually mind the behavior without that tweak, as long as it's explained somewhere.

Ciao, Jonathan