Re: [PATCH] i18n: disable i18n for shell scripts if NO_GETTEXT defined

From: Alex Riesen <raa.lkml@gmail.com>
Date: Jan 20, 2012, 19:45 UTC
Message-ID: <CALxABCYSH4KOtss96dtu8tw0SQd4yFuCaX+XajAY4Fbrdez+7Q@mail.gmail.com>
In-Reply-To: <7vsjjadv5g.fsf@alter.siamese.dyndns.org>

On Fri, Jan 20, 2012 at 20:35, Junio C Hamano <gitster@pobox.com> wrote:

Show 28 quoted lines

> Alex Riesen <raa.lkml@gmail.com> writes:
>
>>> And then a --version for whatever programs that function uses,
>>> e.g. here:
>>>
>>>    $ envsubst --version
>>
>> Nothing. Exit code 127.
>
> Interesting.
>
>    $ wonbsubst --version; echo $?
>    bash: wonbsubst: command not found
>    127
>
> Perhaps your distro lacks a necessary package dependencies between gettext
> and envsubst?
>
>> I believe gettext (the binary) just doesn't start at all here. Maybe
>> some Cygwin library wrong or missing library. Happens all the time
>> here,...
>
> Aha.
>
> I guess we either leave it broken for broken installation or add an extra
> "MY_GETTEXT_IS_BROKEN" option; in either way, it does not sound like a
> serious enough issue that is widespread to be urgently fixed during the
> feature freeze.

Ævar already posted a very cute little fix for this, which looks pretty minimal and is very obvious.

P.S. Sorry for html mail before (tried to use the Android Gmail client).