git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] osxkeychain: define build targets in the top-level Makefile.

From
D. Ben Knoble <ben.knoble@gmail.com>
Date
Feb 17, 2026, 13:10 UTC
Message-ID
<CALnO6CCYorpEzmZwLrb7O-ucKLTOCLp6zXxZr0Qv73tOBqKKig@mail.gmail.com>
In-Reply-To
<CAOTNsDwMeszCC6wunkkx_vhKYx9OvRWXB4VxedypOTQJ6Qs2sA@mail.gmail.com>
On Mon, Feb 16, 2026 at 8:09 PM Koji Nakamaru <koji.nakamaru@gree.net> wrote:
Show 33 quoted lines
>
> On Tue, Feb 17, 2026 at 8:45 AM D. Ben Knoble <ben.knoble@gmail.com> wrote:
> > ...
> >
> > Homebrew picked this patch on top of 2.53.0, and on a recent build on
> > older macOS I needed to
> >
> >     mkdir contrib/credential/osxkeychain/.depend
> >
> > in order to make their build work, since otherwise:
> >
> >     error: error opening
> > 'contrib/credential/osxkeychain/.depend/git-credential-osxkeychain.o.d':
> > No such file or directory
> >     1 error generated.
> >     make[1]: ***
> > [contrib/credential/osxkeychain/git-credential-osxkeychain.o] Error 1
>
> I tried to reproduce this using the current Homebrew formula for git [1]
> on macOS 15.7.4 and 14.8.4 (both relatively newer) with the following
> steps:
>
>   brew tap --force homebrew/core
>   cd "$(brew --repository homebrew/core)"
>   git checkout -B main origin/main
>   git pull
>   HOMEBREW_NO_INSTALL_FROM_API=1 brew reinstall --build-from-source git
>
> In my environment, the build finished successfully. The patch doesn't
> seem to trigger any issues during a local "make" either. How exactly are
> you performing your build?
>
> [1] https://github.com/Homebrew/homebrew-core/blob/9ec3da0dcd3ccd1cd4d892a71377b251770212d7/Formula/g/git.rb

macOS 12.7.6 ;) hence tier 3 Homebrew support + all packages build from source. So just

    brew upgrade git

built 2.53.0 + patches from source. "brew --version" says I have "Homebrew 5.0.14-59-g45db1ce"; it doesn't print a homebrew-core line, so I'm not sure off-hand if that includes the core tap version or not anymore.

I ended up having to use `brew upgrade --debug git`, fix the build error ("mkdir …") and manually perform a few steps when it arose, etc.

-- 
D. Ben Knoble
Previous: Koji NakamaruNext: D. Ben Knoble
Message 9 of 20 in “osxkeychain: define build targets in the top-level Makefile.”
  1. osxkeychain: define build targets in the top-level Makefile.Koji Nakamaru via GitGitGadget, Feb 10, 2026
  2. Junio C HamanoFeb 10, 2026
  3. Koji NakamaruFeb 10, 2026
  4. osxkeychain: define build targets in the top-level Makefile.Koji Nakamaru via GitGitGadget, Feb 11, 2026
  5. Junio C HamanoFeb 11, 2026
  6. Koji NakamaruFeb 11, 2026
  7. D. Ben KnobleFeb 16, 2026
  8. Koji NakamaruFeb 17, 2026
  9. D. Ben KnobleFeb 17, 2026
  10. D. Ben KnobleFeb 17, 2026
  11. Koji NakamaruFeb 17, 2026
  12. D. Ben KnobleFeb 17, 2026
  13. Koji NakamaruFeb 18, 2026
  14. osxkeychain: define build targets in the top-level Makefile.Koji Nakamaru via GitGitGadget, Feb 18, 2026
  15. Kristoffer HaugsbakkFeb 18, 2026
  16. Koji NakamaruFeb 18, 2026
  17. Junio C HamanoFeb 18, 2026
  18. Koji NakamaruFeb 18, 2026
  19. Junio C HamanoFeb 19, 2026
  20. osxkeychain: define build targets in the top-level Makefile.Koji Nakamaru via GitGitGadget, Feb 20, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.