Re: [PATCH v3] osxkeychain: define build targets in the top-level Makefile.
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 18, 2026, 17:55 UTC
- Message-ID
- <xmqq7bsa7x78.fsf@gitster.g>
- In-Reply-To
- <pull.2046.v3.git.1771391650713.gitgitgadget@gmail.com>
"Koji Nakamaru via GitGitGadget" <gitgitgadget@gmail.com> writes:
> +contrib/credential/osxkeychain/git-credential-osxkeychain.o: contrib/credential/osxkeychain/git-credential-osxkeychain.c GIT-CFLAGS > + @mkdir -p contrib/credential/osxkeychain/.depend > + $(QUIET_LINK)$(CC) -o $@ -c $(dep_args) $(compdb_args) $(ALL_CFLAGS) $(EXTRA_CPPFLAGS) $<
I notice that many other places in the Makefile we seem to use $(call mkdir_p_parent_template). Do we want to do so here, too?
Other than that, looking good. Thanks for updating.