Re: [PATCH v2] osxkeychain: define build targets in the top-level Makefile.

From: D. Ben Knoble <ben.knoble@gmail.com>
Date: Feb 16, 2026, 23:45 UTC
Message-ID: <CALnO6CARu8HSYh9=z6FAF=84q1qA4Oan7_DLMbcK+1rth8B7cA@mail.gmail.com>
In-Reply-To: <CAOTNsDz0ZtdsM8Z2NW0WBMGs8xyWz5ROS6pf8DKQAx26LU4xRA@mail.gmail.com>

On Wed, Feb 11, 2026 at 6:06 PM Koji Nakamaru <koji.nakamaru@gree.net> wrote:

Show 16 quoted lines

>
> On Thu, Feb 12, 2026 at 12:37 AM Junio C Hamano <gitster@pobox.com> wrote:
> >
> > "Koji Nakamaru via GitGitGadget" <gitgitgadget@gmail.com> writes:
> >
> > >      -+       cd ../../..; make install-git-credential-osxkeychain
> > >      ++       $(MAKE) -C  ../../.. install-git-credential-osxkeychain
> >
> > Will replace and mark for 'next'.  Will squash the double spaces
> > after "-C" into one while doing so.
>
> Thank you again for the squash and for marking it for 'next'.
>
> --
> Koji Nakamaru
>

Homebrew picked this patch on top of 2.53.0, and on a recent build on older macOS I needed to

    mkdir contrib/credential/osxkeychain/.depend

in order to make their build work, since otherwise:

    error: error opening
'contrib/credential/osxkeychain/.depend/git-credential-osxkeychain.o.d':
No such file or directory
    1 error generated.
    make[1]: ***
[contrib/credential/osxkeychain/git-credential-osxkeychain.o] Error 1

-- 
D. Ben Knoble