Re: [PATCH v3] osxkeychain: define build targets in the top-level Makefile.

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 19, 2026, 15:25 UTC
Message-ID: <xmqqh5rc7o2z.fsf@gitster.g>
In-Reply-To: <CAOTNsDzwb_k+FDBbfzf7z=X=zGhnhXb902Dx9JFGv_eLjza2tQ@mail.gmail.com>

Koji Nakamaru <koji.nakamaru@gree.net> writes:

> Since .depend directories are handled via dep_dirs in this Makefile,
> how about the following change for consistency?

Sounds good.  Thanks for spotting.

Show 34 quoted lines

>
>   diff --git a/Makefile b/Makefile
>   index 1c2019a4cb..47485004d8 100644
>   --- a/Makefile
>   +++ b/Makefile
>   @@ -2876,6 +2876,10 @@ objects: $(OBJECTS)
>    dep_files := $(foreach f,$(OBJECTS),$(dir $f).depend/$(notdir $f).d)
>    dep_dirs := $(addsuffix .depend,$(sort $(dir $(OBJECTS))))
>
>   +ifeq ($(uname_S),Darwin)
>   + dep_dirs += $(addsuffix .depend,$(sort $(dir
> contrib/credential/osxkeychain/git-credential-osxkeychain.o)))
>   +endif
>   +
>    ifeq ($(COMPUTE_HEADER_DEPENDENCIES),yes)
>    $(dep_dirs):
>     @mkdir -p $@
>   @@ -4066,7 +4070,6 @@
> contrib/credential/osxkeychain/git-credential-osxkeychain:
> contrib/credential/os
>     $(filter %.o,$^) $(LIB_FILE) $(EXTLIBS) -framework Security
> -framework CoreFoundation
>
>    contrib/credential/osxkeychain/git-credential-osxkeychain.o:
> contrib/credential/osxkeychain/git-credential-osxkeychain.c GIT-CFLAGS
>   - @mkdir -p contrib/credential/osxkeychain/.depend
>     $(QUIET_LINK)$(CC) -o $@ -c $(dep_args) $(compdb_args)
> $(ALL_CFLAGS) $(EXTRA_CPPFLAGS) $<
>
>    install-git-credential-osxkeychain:
> contrib/credential/osxkeychain/git-credential-osxkeychain
>
> --
> Koji Nakamaru