From: D. Ben Knoble Date: Tue, 17 Feb 2026 13:10:14 GMT Subject: Re: [PATCH v2] osxkeychain: define build targets in the top-level Makefile. Message-ID: In-Reply-To: On Mon, Feb 16, 2026 at 8:09 PM Koji Nakamaru wrote: > > On Tue, Feb 17, 2026 at 8:45 AM D. Ben Knoble wrote: > > ... > > > > Homebrew picked this patch on top of 2.53.0, and on a recent build on > > older macOS I needed to > > > > mkdir contrib/credential/osxkeychain/.depend > > > > in order to make their build work, since otherwise: > > > > error: error opening > > 'contrib/credential/osxkeychain/.depend/git-credential-osxkeychain.o.d': > > No such file or directory > > 1 error generated. > > make[1]: *** > > [contrib/credential/osxkeychain/git-credential-osxkeychain.o] Error 1 > > I tried to reproduce this using the current Homebrew formula for git [1] > on macOS 15.7.4 and 14.8.4 (both relatively newer) with the following > steps: > > brew tap --force homebrew/core > cd "$(brew --repository homebrew/core)" > git checkout -B main origin/main > git pull > HOMEBREW_NO_INSTALL_FROM_API=1 brew reinstall --build-from-source git > > In my environment, the build finished successfully. The patch doesn't > seem to trigger any issues during a local "make" either. How exactly are > you performing your build? > > [1] https://github.com/Homebrew/homebrew-core/blob/9ec3da0dcd3ccd1cd4d892a71377b251770212d7/Formula/g/git.rb macOS 12.7.6 ;) hence tier 3 Homebrew support + all packages build from source. So just brew upgrade git built 2.53.0 + patches from source. "brew --version" says I have "Homebrew 5.0.14-59-g45db1ce"; it doesn't print a homebrew-core line, so I'm not sure off-hand if that includes the core tap version or not anymore. I ended up having to use `brew upgrade --debug git`, fix the build error ("mkdir …") and manually perform a few steps when it arose, etc. -- D. Ben Knoble