Re: [PATCH] osxkeychain: define build targets in the top-level Makefile.

From: Koji Nakamaru <koji.nakamaru@gree.net>
Date: Feb 10, 2026, 23:16 UTC
Message-ID: <CAOTNsDxjuzWUNp4RGABZmPJZBa3wEBXN79kgNPHZCZYsqiOa3g@mail.gmail.com>
In-Reply-To: <xmqqpl6cxtr7.fsf@gitster.g>

On Wed, Feb 11, 2026 at 4:50 AM Junio C Hamano <gitster@pobox.com> wrote:

Show 35 quoted lines

>
> "Koji Nakamaru via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
> >  Makefile                                | 17 +++++++
> >  contrib/credential/osxkeychain/Makefile | 65 +++----------------------
> >  2 files changed, 23 insertions(+), 59 deletions(-)
>
> Nice simplification overall.
>
> > diff --git a/contrib/credential/osxkeychain/Makefile b/contrib/credential/osxkeychain/Makefile
> > index c68445b82d..ddb29f0563 100644
> > --- a/contrib/credential/osxkeychain/Makefile
> > +++ b/contrib/credential/osxkeychain/Makefile
> > @@ -1,66 +1,13 @@
> >  # The default target of this Makefile is...
> >  all:: git-credential-osxkeychain
> >
> > -include ../../../config.mak.uname
> > --include ../../../config.mak.autogen
> > --include ../../../config.mak
> > +git-credential-osxkeychain:
> > +     cd ../../..; make contrib/credential/osxkeychain/git-credential-osxkeychain
>
> Let's not write "make", but stick to $(MAKE), perhaps like
>
>         $(MAKE) -C ../../.. contrib/credential/osxkeychain/$@
>
> > +install:
> > +     cd ../../..; make install-git-credential-osxkeychain
> >
> >  clean:
> > -     $(RM) git-credential-osxkeychain git-credential-osxkeychain.o
> > +     cd ../../..; make clean-git-credential-osxkeychain
>
> Likewise.

Thank you for the review. I'll apply these changes and submit the next iteration soon.

-- Koji Nakamaru