Re: [PATCH v2 1/2] imap-send: avoid leaking the tunnel command

From: Harald Nordgren <haraldnordgren@gmail.com>
Date: Oct 21, 2026, 08:53 UTC
Message-ID: <CAHwyqnW9yRPabz2VCN27RoEw_kCmvGuKQwd-btuMK3vHJVnc8A@mail.gmail.com>
In-Reply-To: <ath21xI1yLScKpuh@pks.im>

Show 7 quoted lines

> >               imap->buf.sock.fd[0] = tunnel.out;
> >               imap->buf.sock.fd[1] = tunnel.in;
> > +             child_process_clear(&tunnel);
>
> This change plugs the memory leak, but the bigger question to me is why
> we never call `finish_command()` on the child process at all. Is there a
> reason for that?

Yeah, that's curious. I'll take a look at handling this better.

Harald

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.