Re: [PATCH v2 2/2] imap-send: accept messages with Subject before Date

From: Patrick Steinhardt <ps@pks.im>
Date: Oct 21, 2026, 09:36 UTC
Message-ID: <atiHnUoDf-_h50V2@pks.im>
In-Reply-To: <CAHwyqnUwbq3XkLajsurk=X_=s3a8Z85Ai2raVmpsxK8HavfwZw@mail.gmail.com>

On Wed, Oct 21, 2026 at 10:45:42AM +0200, Harald Nordgren wrote:

Show 10 quoted lines

> > > @@ -2863,4 +2863,39 @@ test_expect_success $PREREQ '--compose handles to headers' '
> > >       test_cmp expect msgtxt2.to
> > >  '
> > >
> > > +test_expect_success $PREREQ 'imap-send accepts a sent patch from the list archive' '
> >
> > Quite weird that every single test carries this prerequisite. Makes me
> > wonder why we don't just skip all tests at once.
> 
> What do you mean here, do you want to remove the tests?

No, I rather think that we should have this at the beginning of the test file:

        if ! test_have_prereq PERL
        then
        	skip_all='skipping send-email tests; Perl not available'
        	test_done
        fi

Then we can drop the $PREREQ from all tests. But I just spotted that we do some more gymanstics with another prereq that we optionally add later, so this doesn't quite work as-is.

Overall though this is fine, we don't have to fix it as part of this patch series.

Patrick