git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] imap-send: avoid leaking the tunnel command

From
Harald Nordgren via GitGitGadget <gitgitgadget@gmail.com>
Date
Oct 19, 2026, 19:19 UTC
Message-ID
<0784c16134e4b2f9c969e46ffac241e1901b264f.1792437558.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.2456.git.git.1792437558.gitgitgadget@gmail.com>
From: Harald Nordgren <haraldnordgren@gmail.com>

When imap.tunnel is set, imap_open_store() starts the tunnel but never releases the child_process used for it, which leaks its argument list. No test sets imap.tunnel, so the leak checker has not caught this.

Only the pipes to the tunnel are needed once it is running, so release the rest right after starting it.

Signed-off-by: Harald Nordgren <haraldnordgren@gmail.com>
---
 imap-send.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/imap-send.c b/imap-send.c
index bf1d2cf74d..6f76bade35 100644
--- a/imap-send.c
+++ b/imap-send.c
@@ -1176,6 +1176,7 @@ static struct imap_store *imap_open_store(struct imap_server_conf *srvc, const c
 
 		imap->buf.sock.fd[0] = tunnel.out;
 		imap->buf.sock.fd[1] = tunnel.in;
+		child_process_clear(&tunnel);
 
 		imap_info("OK\n");
 	} else {
-- 
gitgitgadget
Previous: Harald Nordgren via GitGitGadgetNext: Harald Nordgren via GitGitGadget
Message 2 of 32 in “Fix imap-send with reordered message headers”
  1. 0/2 Fix imap-send with reordered message headersHarald Nordgren via GitGitGadget, Oct 19, 2026
  2. 1/2 imap-send: avoid leaking the tunnel commandHarald Nordgren via GitGitGadget, Oct 19, 2026
  3. 2/2 imap-send: accept messages with Subject before DateHarald Nordgren via GitGitGadget, Oct 19, 2026
  4. Junio C HamanoOct 19, 2026
  5. Harald NordgrenOct 20, 2026
  6. 0/2 Fix imap-send with reordered message headersHarald Nordgren via GitGitGadget, Oct 21, 2026
  7. 1/2 imap-send: avoid leaking the tunnel commandHarald Nordgren via GitGitGadget, Oct 21, 2026
  8. Patrick SteinhardtOct 21, 2026
  9. Harald NordgrenOct 21, 2026
  10. 2/2 imap-send: accept messages with Subject before DateHarald Nordgren via GitGitGadget, Oct 21, 2026
  11. Patrick SteinhardtOct 21, 2026
  12. Harald NordgrenOct 21, 2026
  13. Patrick SteinhardtOct 21, 2026
  14. Harald NordgrenOct 21, 2026
  15. 0/4 Fix imap-send with reordered message headersHarald Nordgren via GitGitGadget, Oct 22, 2026
  16. 1/4 imap-send: wait for the tunnel command to finishHarald Nordgren via GitGitGadget, Oct 22, 2026
  17. Patrick SteinhardtOct 26, 2026
  18. Harald NordgrenOct 26, 2026
  19. 2/4 imap-send: accept messages with Subject before DateHarald Nordgren via GitGitGadget, Oct 22, 2026
  20. 3/4 imap-send: check git send-email copies like other messagesHarald Nordgren via GitGitGadget, Oct 22, 2026
  21. Patrick SteinhardtOct 26, 2026
  22. Harald NordgrenOct 26, 2026
  23. 4/4 imap-send: match header names case insensitivelyHarald Nordgren via GitGitGadget, Oct 22, 2026
  24. Patrick SteinhardtOct 26, 2026
  25. 0/4 Fix imap-send with reordered message headersHarald Nordgren via GitGitGadget, Oct 27, 2026
  26. 1/4 imap-send: wait for the tunnel command to finishHarald Nordgren via GitGitGadget, Oct 27, 2026
  27. 2/4 imap-send: accept messages with Subject before DateHarald Nordgren via GitGitGadget, Oct 27, 2026
  28. 3/4 imap-send: check git send-email copies like other messagesHarald Nordgren via GitGitGadget, Oct 27, 2026
  29. Patrick SteinhardtOct 27, 2026
  30. 4/4 imap-send: match header names case insensitivelyHarald Nordgren via GitGitGadget, Oct 27, 2026
  31. Patrick SteinhardtOct 27, 2026
  32. Junio C HamanoOct 29, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.