git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v4 4/4] imap-send: match header names case insensitively

From
Harald Nordgren via GitGitGadget <gitgitgadget@gmail.com>
Date
Oct 27, 2026, 08:31 UTC
Message-ID
<5b4a08bbdadac95a84f9c865e697584f45bd67af.1793089879.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.2456.v4.git.git.1793089879.gitgitgadget@gmail.com>
From: Harald Nordgren <haraldnordgren@gmail.com>

imap-send says "no messages found to send" for a message whose headers are spelled "from:", "date:" or "subject:", although RFC 5322 treats header field names as case insensitive. Match the three names in any case.

Signed-off-by: Harald Nordgren <haraldnordgren@gmail.com>
---
 imap-send.c           |  6 +++---
 t/t9001-send-email.sh | 15 +++++++++++++++
 2 files changed, 18 insertions(+), 3 deletions(-)
diff --git a/imap-send.c b/imap-send.c
index 706c517e51..b8dac92c70 100644
--- a/imap-send.c
+++ b/imap-send.c
@@ -1462,11 +1462,11 @@ static bool has_required_headers(const char *line)
 	bool from = false, date = false, subject = false;
 
 	while ((line = strchr(line, '\n')) && *++line != '\n') {
-		if (starts_with(line, "From: "))
+		if (istarts_with(line, "From: "))
 			from = true;
-		else if (starts_with(line, "Date: "))
+		else if (istarts_with(line, "Date: "))
 			date = true;
-		else if (starts_with(line, "Subject: "))
+		else if (istarts_with(line, "Subject: "))
 			subject = true;
 	}
 	return from && date && subject;
diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
index 1f77c14315..897473e786 100755
--- a/t/t9001-send-email.sh
+++ b/t/t9001-send-email.sh
@@ -2898,4 +2898,19 @@ test_expect_success $PREREQ '--imap-sent-folder stores a copy of the sent patch'
 	test_grep "(1/1) done" err
 '
 
+test_expect_success $PREREQ 'imap-send matches header names in any case' '
+	test_config imap.tunnel ./fake-imap-server &&
+	cat >lowercase.mbox <<-\EOF &&
+	From mboxrd@z Thu Jan  1 00:00:00 1970
+	from: Example <from@example.com>
+	date: Thu, 1 Jan 1970 00:00:00 +0000
+	subject: [PATCH] lowercase headers
+
+	body
+	EOF
+	git imap-send --folder=INBOX <lowercase.mbox 2>err &&
+	test_grep "^Sending 1 message to INBOX folder" err &&
+	test_grep "(1/1) done" err
+'
+
 test_done
-- 
gitgitgadget
Previous: Patrick SteinhardtNext: Patrick Steinhardt
Message 30 of 32 in “Fix imap-send with reordered message headers”
  1. 0/2 Fix imap-send with reordered message headersHarald Nordgren via GitGitGadget, Oct 19, 2026
  2. 1/2 imap-send: avoid leaking the tunnel commandHarald Nordgren via GitGitGadget, Oct 19, 2026
  3. 2/2 imap-send: accept messages with Subject before DateHarald Nordgren via GitGitGadget, Oct 19, 2026
  4. Junio C HamanoOct 19, 2026
  5. Harald NordgrenOct 20, 2026
  6. 0/2 Fix imap-send with reordered message headersHarald Nordgren via GitGitGadget, Oct 21, 2026
  7. 1/2 imap-send: avoid leaking the tunnel commandHarald Nordgren via GitGitGadget, Oct 21, 2026
  8. Patrick SteinhardtOct 21, 2026
  9. Harald NordgrenOct 21, 2026
  10. 2/2 imap-send: accept messages with Subject before DateHarald Nordgren via GitGitGadget, Oct 21, 2026
  11. Patrick SteinhardtOct 21, 2026
  12. Harald NordgrenOct 21, 2026
  13. Patrick SteinhardtOct 21, 2026
  14. Harald NordgrenOct 21, 2026
  15. 0/4 Fix imap-send with reordered message headersHarald Nordgren via GitGitGadget, Oct 22, 2026
  16. 1/4 imap-send: wait for the tunnel command to finishHarald Nordgren via GitGitGadget, Oct 22, 2026
  17. Patrick SteinhardtOct 26, 2026
  18. Harald NordgrenOct 26, 2026
  19. 2/4 imap-send: accept messages with Subject before DateHarald Nordgren via GitGitGadget, Oct 22, 2026
  20. 3/4 imap-send: check git send-email copies like other messagesHarald Nordgren via GitGitGadget, Oct 22, 2026
  21. Patrick SteinhardtOct 26, 2026
  22. Harald NordgrenOct 26, 2026
  23. 4/4 imap-send: match header names case insensitivelyHarald Nordgren via GitGitGadget, Oct 22, 2026
  24. Patrick SteinhardtOct 26, 2026
  25. 0/4 Fix imap-send with reordered message headersHarald Nordgren via GitGitGadget, Oct 27, 2026
  26. 1/4 imap-send: wait for the tunnel command to finishHarald Nordgren via GitGitGadget, Oct 27, 2026
  27. 2/4 imap-send: accept messages with Subject before DateHarald Nordgren via GitGitGadget, Oct 27, 2026
  28. 3/4 imap-send: check git send-email copies like other messagesHarald Nordgren via GitGitGadget, Oct 27, 2026
  29. Patrick SteinhardtOct 27, 2026
  30. 4/4 imap-send: match header names case insensitivelyHarald Nordgren via GitGitGadget, Oct 27, 2026
  31. Patrick SteinhardtOct 27, 2026
  32. Junio C HamanoOct 29, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.