Re: [PATCH v2 2/2] imap-send: accept messages with Subject before Date
Show 18 quoted lines
> > Patches sent with git send-email cannot be fed back into git imap-send
> > after fetching them from the mailing list archive, for example with
> >
> > b4 mbox --single-message -o - <url> | git imap-send
> >
> > which fails with "no messages found to send". imap-send only counts a
> > message when its From, Date and Subject headers come in that order,
> > and git send-email writes Subject before Date.
> >
> > Accept the three headers in any order within the header block of each
> > message, and match their names case insensitively as RFC 5322
> > specifies. The copy that git send-email --imap-sent-folder pipes to
> > imap-send then passes the same check, so the special case added for it
> > in 04133f5bc4 (send-email: add ability to send a copy of sent emails to
> > an IMAP folder, 2025-08-12) is no longer needed.
>
> Aren't you fixing two different issues at once? I'd argue that this
> should be done in separate commits.
Show 8 quoted lines
> > @@ -2863,4 +2863,39 @@ test_expect_success $PREREQ '--compose handles to headers' '
> > test_cmp expect msgtxt2.to
> > '
> >
> > +test_expect_success $PREREQ 'imap-send accepts a sent patch from the list archive' '
>
> Quite weird that every single test carries this prerequisite. Makes me
> wonder why we don't just skip all tests at once.
What do you mean here, do you want to remove the tests?
Harald