git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/2] imap-send: accept messages with Subject before Date

From
Harald Nordgren <haraldnordgren@gmail.com>
Date
Oct 21, 2026, 08:45 UTC
Message-ID
<CAHwyqnUwbq3XkLajsurk=X_=s3a8Z85Ai2raVmpsxK8HavfwZw@mail.gmail.com>
In-Reply-To
<ath23vYy0n8UFLUB@pks.im>
Show 18 quoted lines
> > Patches sent with git send-email cannot be fed back into git imap-send
> > after fetching them from the mailing list archive, for example with
> >
> >     b4 mbox --single-message -o - <url> | git imap-send
> >
> > which fails with "no messages found to send". imap-send only counts a
> > message when its From, Date and Subject headers come in that order,
> > and git send-email writes Subject before Date.
> >
> > Accept the three headers in any order within the header block of each
> > message, and match their names case insensitively as RFC 5322
> > specifies. The copy that git send-email --imap-sent-folder pipes to
> > imap-send then passes the same check, so the special case added for it
> > in 04133f5bc4 (send-email: add ability to send a copy of sent emails to
> > an IMAP folder, 2025-08-12) is no longer needed.
>
> Aren't you fixing two different issues at once? I'd argue that this
> should be done in separate commits.
Good point.
Show 8 quoted lines
> > @@ -2863,4 +2863,39 @@ test_expect_success $PREREQ '--compose handles to headers' '
> >       test_cmp expect msgtxt2.to
> >  '
> >
> > +test_expect_success $PREREQ 'imap-send accepts a sent patch from the list archive' '
>
> Quite weird that every single test carries this prerequisite. Makes me
> wonder why we don't just skip all tests at once.
What do you mean here, do you want to remove the tests?
Harald
Previous: Patrick SteinhardtNext: Patrick Steinhardt
Message 12 of 32 in “Fix imap-send with reordered message headers”
  1. 0/2 Fix imap-send with reordered message headersHarald Nordgren via GitGitGadget, Oct 19, 2026
  2. 1/2 imap-send: avoid leaking the tunnel commandHarald Nordgren via GitGitGadget, Oct 19, 2026
  3. 2/2 imap-send: accept messages with Subject before DateHarald Nordgren via GitGitGadget, Oct 19, 2026
  4. Junio C HamanoOct 19, 2026
  5. Harald NordgrenOct 20, 2026
  6. 0/2 Fix imap-send with reordered message headersHarald Nordgren via GitGitGadget, Oct 21, 2026
  7. 1/2 imap-send: avoid leaking the tunnel commandHarald Nordgren via GitGitGadget, Oct 21, 2026
  8. Patrick SteinhardtOct 21, 2026
  9. Harald NordgrenOct 21, 2026
  10. 2/2 imap-send: accept messages with Subject before DateHarald Nordgren via GitGitGadget, Oct 21, 2026
  11. Patrick SteinhardtOct 21, 2026
  12. Harald NordgrenOct 21, 2026
  13. Patrick SteinhardtOct 21, 2026
  14. Harald NordgrenOct 21, 2026
  15. 0/4 Fix imap-send with reordered message headersHarald Nordgren via GitGitGadget, Oct 22, 2026
  16. 1/4 imap-send: wait for the tunnel command to finishHarald Nordgren via GitGitGadget, Oct 22, 2026
  17. Patrick SteinhardtOct 26, 2026
  18. Harald NordgrenOct 26, 2026
  19. 2/4 imap-send: accept messages with Subject before DateHarald Nordgren via GitGitGadget, Oct 22, 2026
  20. 3/4 imap-send: check git send-email copies like other messagesHarald Nordgren via GitGitGadget, Oct 22, 2026
  21. Patrick SteinhardtOct 26, 2026
  22. Harald NordgrenOct 26, 2026
  23. 4/4 imap-send: match header names case insensitivelyHarald Nordgren via GitGitGadget, Oct 22, 2026
  24. Patrick SteinhardtOct 26, 2026
  25. 0/4 Fix imap-send with reordered message headersHarald Nordgren via GitGitGadget, Oct 27, 2026
  26. 1/4 imap-send: wait for the tunnel command to finishHarald Nordgren via GitGitGadget, Oct 27, 2026
  27. 2/4 imap-send: accept messages with Subject before DateHarald Nordgren via GitGitGadget, Oct 27, 2026
  28. 3/4 imap-send: check git send-email copies like other messagesHarald Nordgren via GitGitGadget, Oct 27, 2026
  29. Patrick SteinhardtOct 27, 2026
  30. 4/4 imap-send: match header names case insensitivelyHarald Nordgren via GitGitGadget, Oct 27, 2026
  31. Patrick SteinhardtOct 27, 2026
  32. Junio C HamanoOct 29, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.