From: Harald Nordgren <haraldnordgren@gmail.com>
Date: Wed, 21 Oct 2026 08:53:43 GMT
Subject: Re: [PATCH v2 1/2] imap-send: avoid leaking the tunnel command
Message-ID: <CAHwyqnW9yRPabz2VCN27RoEw_kCmvGuKQwd-btuMK3vHJVnc8A@mail.gmail.com>
In-Reply-To: <ath21xI1yLScKpuh@pks.im>

> >               imap->buf.sock.fd[0] = tunnel.out;
> >               imap->buf.sock.fd[1] = tunnel.in;
> > +             child_process_clear(&tunnel);
>
> This change plugs the memory leak, but the bigger question to me is why
> we never call `finish_command()` on the child process at all. Is there a
> reason for that?

Yeah, that's curious. I'll take a look at handling this better.


Harald