git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] remote.c: defer remote.<name>.followRemoteHEAD validation

From
Colin Hinton <colinlewishinton@gmail.com>
Date
Nov 8, 2026, 21:45 UTC
Message-ID
<CAHeTm9M5maWM=yrJPNzCibv_rewH3-yBK8J5-MDyDvPzfihe4A@mail.gmail.com>
In-Reply-To
<xmqq1p8ylywh.fsf@gitster.g>

I prefer Matt's approach as I agree it's cleaner and simpler by removing the setup at the call site. I'll adopt it into my next version and will give credit to Matt for his contribution.

I am still holding on to the re-roll until hn/fetch-refmap is accepted into 'next', so that I can rebase and resolve any conflicts myself. Junio, if you think there is a better branch for me to base this off of so that I can begin the conflict resolution now please let me know.

-Colin Hinton
On Fri, Nov 6, 2026 at 8:15 AM Junio C Hamano <gitster@pobox.com> wrote:
Show 28 quoted lines
>
> "Matt Hunter" <m@lfurio.us> writes:
>
> > On Thu Nov 5, 2026 at 11:03 PM EST, Junio C Hamano wrote:
> >>
> >> Hmph, interesting.  Can you rewrite Colin's patch using this, and
> >> then merge the result into 'seen' (after reverting Colin's topic
> >> ch/remote-defer-follow-remote-head-validation from 'seen' first) to
> >> see how badly it crashes with other topics in flight?
> >
> > I still have the commit sitting around.  I tried this and a replay of
> > the current topic to compare -- the conflict is the same in both
> > cases.  eg: Nothing else in flight is touching the
> > get_follow_remote_head() function.
>
> Thanks for investigating.
>
> Your approach of passing more context into get_follow_remote_head()
> and have _it_ do the (lazy) conversion from string to value makes it
> much easier for callers to make calls from multiple branches to the
> function, because the need to "set-up" to make the call disappears.
>
> Very cleanly done.
>
> Colin, what's your preference?  Can we move this topic past the
> finish line?
>
> Thanks.
Previous: Junio C Hamano
Message 19 of 19 in “remote.c: defer remote.<name>.followRemoteHEAD validation”
  1. remote.c: defer remote.<name>.followRemoteHEAD validationColin Hinton, Oct 18, 2026
  2. Junio C HamanoOct 19, 2026
  3. Matt HunterOct 19, 2026
  4. Colin HintonOct 21, 2026
  5. Matt HunterOct 22, 2026
  6. remote.c: defer remote.<name>.followRemoteHEAD validationColin Hinton, Oct 23, 2026
  7. Junio C HamanoOct 23, 2026
  8. Matt HunterOct 24, 2026
  9. Junio C HamanoOct 24, 2026
  10. Junio C HamanoOct 25, 2026
  11. Colin HintonOct 28, 2026
  12. Junio C HamanoOct 28, 2026
  13. Matt HunterOct 30, 2026
  14. Junio C HamanoOct 30, 2026
  15. Matt HunterNov 1, 2026
  16. Junio C HamanoNov 6, 2026
  17. Matt HunterNov 6, 2026
  18. Junio C HamanoNov 6, 2026
  19. Colin HintonNov 8, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.