Re: [PATCH v2] remote.c: defer remote.<name>.followRemoteHEAD validation
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 6, 2026, 16:15 UTC
- Message-ID
- <xmqq1p8ylywh.fsf@gitster.g>
- In-Reply-To
- <DMO0XC1PL4MP.1J5830XZ4GCS5@lfurio.us>
"Matt Hunter" <m@lfurio.us> writes:
Show 11 quoted lines
> On Thu Nov 5, 2026 at 11:03 PM EST, Junio C Hamano wrote: >> >> Hmph, interesting. Can you rewrite Colin's patch using this, and >> then merge the result into 'seen' (after reverting Colin's topic >> ch/remote-defer-follow-remote-head-validation from 'seen' first) to >> see how badly it crashes with other topics in flight? > > I still have the commit sitting around. I tried this and a replay of > the current topic to compare -- the conflict is the same in both > cases. eg: Nothing else in flight is touching the > get_follow_remote_head() function.
Thanks for investigating.
Your approach of passing more context into get_follow_remote_head() and have _it_ do the (lazy) conversion from string to value makes it much easier for callers to make calls from multiple branches to the function, because the need to "set-up" to make the call disappears.
Very cleanly done.
Colin, what's your preference? Can we move this topic past the finish line?
Thanks.