git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] remote.c: defer remote.<name>.followRemoteHEAD validation

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 30, 2026, 15:12 UTC
Message-ID
<xmqq33tnz0hb.fsf@gitster.g>
In-Reply-To
<DMHZCS9LOW3N.ZJ3947HUCXZ8@lfurio.us>
"Matt Hunter" <m@lfurio.us> writes:
Show 10 quoted lines
> On Wed Oct 28, 2026 at 10:26 AM EDT, Junio C Hamano wrote:
>>
>>>> This part of the code becomes overly deeply indented, and more
>>>> importantly, the outer conditional around here has been reworked by
>>>> another topic and the code that learns follow_remote_head will have
>>>> to be reused elsewhere, which would lead to a nasty merge conflict.
> ...
> I wonder if it makes sense to incorporate such a new helper function
> into the existing 'get_follow_remote_head()', since it would be the only
> place using it.

I am not sure what being the only place has to do with avoiding to split a helper function out to clarify the main logic flow, though. And simultaneously, another topic wants to have this piece of logic twice.

Previous: Matt HunterNext: Matt Hunter
Message 14 of 19 in “remote.c: defer remote.<name>.followRemoteHEAD validation”
  1. remote.c: defer remote.<name>.followRemoteHEAD validationColin Hinton, Oct 18, 2026
  2. Junio C HamanoOct 19, 2026
  3. Matt HunterOct 19, 2026
  4. Colin HintonOct 21, 2026
  5. Matt HunterOct 22, 2026
  6. remote.c: defer remote.<name>.followRemoteHEAD validationColin Hinton, Oct 23, 2026
  7. Junio C HamanoOct 23, 2026
  8. Matt HunterOct 24, 2026
  9. Junio C HamanoOct 24, 2026
  10. Junio C HamanoOct 25, 2026
  11. Colin HintonOct 28, 2026
  12. Junio C HamanoOct 28, 2026
  13. Matt HunterOct 30, 2026
  14. Junio C HamanoOct 30, 2026
  15. Matt HunterNov 1, 2026
  16. Junio C HamanoNov 6, 2026
  17. Matt HunterNov 6, 2026
  18. Junio C HamanoNov 6, 2026
  19. Colin HintonNov 8, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.