Re: [PATCH v2] remote.c: defer remote.<name>.followRemoteHEAD validation
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 30, 2026, 15:12 UTC
- Message-ID
- <xmqq33tnz0hb.fsf@gitster.g>
- In-Reply-To
- <DMHZCS9LOW3N.ZJ3947HUCXZ8@lfurio.us>
"Matt Hunter" <m@lfurio.us> writes:
Show 10 quoted lines
> On Wed Oct 28, 2026 at 10:26 AM EDT, Junio C Hamano wrote: >> >>>> This part of the code becomes overly deeply indented, and more >>>> importantly, the outer conditional around here has been reworked by >>>> another topic and the code that learns follow_remote_head will have >>>> to be reused elsewhere, which would lead to a nasty merge conflict. > ... > I wonder if it makes sense to incorporate such a new helper function > into the existing 'get_follow_remote_head()', since it would be the only > place using it.
I am not sure what being the only place has to do with avoiding to split a helper function out to clarify the main logic flow, though. And simultaneously, another topic wants to have this piece of logic twice.