Re: [PATCH v2] remote.c: defer remote.<name>.followRemoteHEAD validation
- From
Colin Hinton <colinlewishinton@gmail.com>
- Date
- Oct 28, 2026, 02:56 UTC
- Message-ID
- <CAHeTm9NOqLA=BfTU9ABDFt8+jOzaRDPRrMNP8thzAQN2NVZAew@mail.gmail.com>
- In-Reply-To
- <xmqqecdezfr1.fsf@gitster.g>
Show 9 quoted lines
> This part of the code becomes overly deeply indented, and more > importantly, the outer conditional around here has been reworked by > another topic and the code that learns follow_remote_head will have > to be reused elsewhere, which would lead to a nasty merge conflict. > > I'd like to see this part refactored into a separate helper > function, by squashing something like this on top of this patch. > > Thanks.
Okay, I will refactor this into a helper method since yes the intending is becoming too much, I will also keep my eye on the patch you previously mentioned, and post a new version once Next has been updated from Harald's work so I can rebase with their fixes. Thanks for the feedback.
-Colin Hinton