From: Colin Hinton Date: Sun, 08 Nov 2026 21:45:16 GMT Subject: Re: [PATCH v2] remote.c: defer remote..followRemoteHEAD validation Message-ID: In-Reply-To: I prefer Matt's approach as I agree it's cleaner and simpler by removing the setup at the call site. I'll adopt it into my next version and will give credit to Matt for his contribution. I am still holding on to the re-roll until hn/fetch-refmap is accepted into 'next', so that I can rebase and resolve any conflicts myself. Junio, if you think there is a better branch for me to base this off of so that I can begin the conflict resolution now please let me know. -Colin Hinton On Fri, Nov 6, 2026 at 8:15 AM Junio C Hamano wrote: > > "Matt Hunter" writes: > > > On Thu Nov 5, 2026 at 11:03 PM EST, Junio C Hamano wrote: > >> > >> Hmph, interesting. Can you rewrite Colin's patch using this, and > >> then merge the result into 'seen' (after reverting Colin's topic > >> ch/remote-defer-follow-remote-head-validation from 'seen' first) to > >> see how badly it crashes with other topics in flight? > > > > I still have the commit sitting around. I tried this and a replay of > > the current topic to compare -- the conflict is the same in both > > cases. eg: Nothing else in flight is touching the > > get_follow_remote_head() function. > > Thanks for investigating. > > Your approach of passing more context into get_follow_remote_head() > and have _it_ do the (lazy) conversion from string to value makes it > much easier for callers to make calls from multiple branches to the > function, because the need to "set-up" to make the call disappears. > > Very cleanly done. > > Colin, what's your preference? Can we move this topic past the > finish line? > > Thanks.