Re: [PATCH v2] remote.c: defer remote.<name>.followRemoteHEAD validation
- From
Matt Hunter <m@lfurio.us>
- Date
- Oct 24, 2026, 09:28 UTC
- Message-ID
- <DMCYNNPMFVMA.S74D9Y3OQ9QE@lfurio.us>
- In-Reply-To
- <20261023185007.21642-1-colinlewishinton@gmail.com>
On Fri Oct 23, 2026 at 2:50 PM EDT, Colin Hinton wrote:
Show 30 quoted lines
> Continuing from 86129fd (fetch.c: defer fetch.followRemoteHEAD > validation), apply the same treatment to > remote.<name>.followRemoteHEAD, which is still validated in > handle_config(). That emits a warning for any command that loads the > remote configuration, such as "git push" or "git remote -v", even > though only "git fetch" ever consults the value. > > Store the raw string in struct remote instead, and resolve it lazily > in do_fetch() through the get_follow_remote_head() helper introduced > by 86129fd. This replaces the parsed follow_remote_head and > no_warn_branch members, and the NEEDSWORK comment left behind by > 86129fd is removed. "git remote set-head" now compares against the > raw string to decide whether to rewrite "always" to "warn". > > Moved enum follow_remote_head_settings to builtin/fetch.c as it is no > longer referenced in remote. > > Messages for an unrecognized or missing value name the full variable > name prefix, as the helper now serves both the fetch-level and > the remote-level setting. > > Signed-off-by: Colin Hinton <colinlewishinton@gmail.com> > --- > Documentation/config/remote.adoc | 4 +-- > builtin/fetch.c | 45 +++++++++++++++++++++----------- > builtin/remote.c | 3 ++- > remote.c | 28 +++----------------- > remote.h | 13 ++------- > t/t5510-fetch.sh | 18 +++++++++++++ > 6 files changed, 58 insertions(+), 53 deletions(-)
Besides Junio's whitespace notes, I have no additional comments. Looks good.
Thanks