Re: [PATCH] git-compat-util: Avoid strcasecmp() being inlined

From: Sebastian Schuberth <sschuberth@gmail.com>
Date: Sep 13, 2013, 19:34 UTC
Message-ID: <CAHGBnuNu7G+6T8jySwNfkjrUaQZzwxf5ginq+x0S1erY6L_ZoQ@mail.gmail.com>
In-Reply-To: <xmqqtxhokdao.fsf@gitster.dls.corp.google.com>

On Fri, Sep 13, 2013 at 4:26 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 17 quoted lines

>>> Perhaps the real issue is that the header file does not give an
>>> equivalent "those who want to take the address of strcasecmp will
>>> get the address of _stricmp instead" macro, e.g.
>>>
>>>         #define strcasecmp _stricmp
>>>
>>> or something?
>>
>> Now it's you who puzzles me, because the header file *does* have
>> exactly the macro that you suggest.
>
> Then why does your platform have problem with the code that takes
> the address of strcasecmp and stores it in the variable?  It is not
> me, but your platform that is puzzling us.
>
> There is something else going on, like you do not have that #define
> "enabled" under some condition, or something silly like that.

Exactly. That define is only enabled if __NO_INLINE__ is defined. Which is what my patch is all about: Define __NO_INLINE__ so that we get "#define strcasecmp _stricmp".

-- 
Sebastian Schuberth