Re: [PATCH] git-compat-util: Avoid strcasecmp() being inlined

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Sep 12, 2013, 21:31 UTC
Message-ID: <20130912213149.GK4326@google.com>
In-Reply-To: <CAHGBnuPzzokV7YMrx0gAL1VACcmaLwFoaB3n6bX8Y-UDHs7S8A@mail.gmail.com>

Sebastian Schuberth wrote:

Show 6 quoted lines

> And that's exactly what defining __NO_INLINE__ does. Granted, defining
> __NO_INLINE__ in the scope of string.h will also add a "#define
> strcasecmp _stricmp"; but despite it's name, defining __NO_INLINE__
> does not imply a performance hit due to functions not being inlined
> because it's just the "strncasecmp" wrapper around "_strnicmp" that's
> being inlined, not "_strnicmp" itself.

What I don't understand is why the header doesn't use "static inline" instead of "extern inline". The former would seem to be better in every way for this particular use case.

See also <http://www.greenend.org.uk/rjk/tech/inline.html>, section "GNU C inline rules".

Thanks, Jonathan