Re: [PATCH] git-compat-util: Avoid strcasecmp() being inlined

From

Jonathan Nieder <jrnieder@gmail.com>

Date

Sep 12, 2013, 18:38 UTC

Message-ID

<20130912183849.GI4326@google.com>

In-Reply-To

<xmqqd2odq45y.fsf@gitster.dls.corp.google.com>

Junio C Hamano wrote:

> I think we would want something like below.

Looks good to me, but

> -- >8 --
> Subject: [PATCH] mailmap: work around implementations with pure inline strcasecmp
>
> On some systems, string.h has _only_ inline definition of strcasecmp

Please specify which system we are talking about: s/some systems/MinGW 4.0/

[...]

> --- a/mailmap.c
> +++ b/mailmap.c
> @@ -52,6 +52,19 @@ static void free_mailmap_entry(void *p, const char *s)
>  	string_list_clear_func(&me->namemap, free_mailmap_info);
>  }
>  
> +/*
> + * On some systems, string.h has _only_ inline definition of strcasecmp

Likewise.

With or without that change,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>