Re: [PATCH] git-compat-util: Avoid strcasecmp() being inlined

From: Jeff King <peff@peff.net>
Date: Sep 19, 2013, 22:05 UTC
Message-ID: <20130919220531.GA13723@sigill.intra.peff.net>
In-Reply-To: <xmqqy56sqxj1.fsf@gitster.dls.corp.google.com>

On Thu, Sep 19, 2013 at 03:03:46PM -0700, Junio C Hamano wrote:

Show 12 quoted lines

> >> But only when someone compiles on MinGW, no?
> >
> > Yeah. I think a more clear way to phrase the question would be: is there
> > some trick we can use to booby-trap strcasecmp as a function pointer so
> > that it fails to compile even on systems where it would otherwise work?
> 
> That line of thought nudges us toward the place Linus explicitly
> said he didn't want to see us going, no?  We do not particularly
> want to care the exact nature of the breakage on MinGW.  Do we
> really want to set a booby-trap that intimately knows about how
> their strcasecmp is broken, and possibly cover breakages of the same
> kind but with other functions?

Exactly. You snipped my second paragraph, but the gist of it was "...and no, we do not want to go there". Calling it a booby-trap was meant to be derogatory. :)

-Peff