Re: [PATCH] git-compat-util: Avoid strcasecmp() being inlined

From: Jeff King <peff@peff.net>
Date: Sep 12, 2013, 18:20 UTC
Message-ID: <20130912182057.GB32069@sigill.intra.peff.net>
In-Reply-To: <xmqq61u6qcez.fsf@gitster.dls.corp.google.com>

On Thu, Sep 12, 2013 at 08:37:08AM -0700, Junio C Hamano wrote:

Show 11 quoted lines

> > I wonder if GCC has changed it's behaviour to more closely match C99.
> > Clang as a compatibility article about this sort of issue:
> >
> >     http://clang.llvm.org/compatibility.html#inline
> 
> Interesting.  The ways the page suggests as fixes are
> 
>  - change it to a "statis inline";
>  - remove "inline" from the definition;
>  - provide an external (non-inline) def somewhere else;
>  - compile with gnu899 dialect.

Right, option 3 seems perfectly reasonable to me, as we must be prepared to cope with a decision not to inline the function, and there has to be _some_ linked implementation. But shouldn't libc be providing an external, linkable strcasecmp in this case?

-Peff