Re: [PATCH] git-compat-util: Avoid strcasecmp() being inlined

From: Piotr Krukowiecki <piotr.krukowiecki@gmail.com>
Date: Sep 19, 2013, 09:47 UTC
Message-ID: <CAA01CspCWFMGxXs9M3A1mtTctiUCCeJ9pJjHt=auMjhHHJU3Dg@mail.gmail.com>
In-Reply-To: <CAPc5daVt4Q9twub5KyOQqZHx9CwOnkuwA97sXV44fF2j1e5HVg@mail.gmail.com>

On Thu, Sep 19, 2013 at 9:37 AM, Junio C Hamano <junio@pobox.com> wrote:

Show 5 quoted lines

> On Sep 18, 2013 11:08 PM, "Piotr Krukowiecki" <piotr.krukowiecki@gmail.com>
> wrote:
>>
>> On Wed, Sep 11, 2013 at 9:16 PM, Jeff King <peff@peff.net> wrote:
>> > I would prefer the static wrapper solution you suggest, though. It

[...]

Show 7 quoted lines

>> > it still ends up as a single function call). The downside is that it has
>> > to be remembered at each site that uses strcasecmp, but we do not use
>> > pointers to standard library functions very often.
>>
>> Is it possible to add a test which fails if wrapper is not used?
>
> No test needed for this, as compilation or linkage will fail, I think.

But only when someone compiles on MinGW, no?

-- 
Piotr Krukowiecki