Re: [PATCH v5 16/16] reftable: be more paranoid about 0-length memcpy calls

From: Han-Wen Nienhuys <hanwen@google.com>
Date: Jan 12, 2022, 12:59 UTC
Message-ID: <CAFQ2z_PH5p3KZoHHQ28ouSK3azy_o_wzEObfyQi=z7Bv5o4BRw@mail.gmail.com>
In-Reply-To: <CAFQ2z_PDfreeGttTbNTbnr7rRJQFHFfLVD_hJu21QQAR1njPpg@mail.gmail.com>

On Wed, Jan 12, 2022 at 12:39 PM Han-Wen Nienhuys <hanwen@google.com> wrote:

> this series, I'll just take a closer look at the current call-sites to
> see if NULL can really occur or not.

I've dropped this patch from the series. The only suspect callsite is in obj_record_decode(), and that is better addressed by other changes to make sure we never try to do a 0 length copy.

-- 
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--

Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado