Re: [PATCH 10/10] reftable: make reftable_record a tagged union

From: Han-Wen Nienhuys <hanwen@google.com>
Date: Dec 8, 2021, 10:30 UTC
Message-ID: <CAFQ2z_NuOy+-pfSoNAYjJhS9jZCYOfoFue10=k=iyPVsPYrB3g@mail.gmail.com>
In-Reply-To: <xmqq4k7j68eg.fsf@gitster.g>

On Wed, Dec 8, 2021 at 5:13 AM Junio C Hamano <gitster@pobox.com> wrote:

Show 8 quoted lines

> >> error: ISO C99 doesn't support unnamed structs/unions [-Werror=pedantic]
> >
> > Hmm. It's interesting that the regular DEVELOPER=1 doesn't catch this.
> > It's because we don't specify -std there, and newer gcc defaults to
> > gnu17 (unnamed unions appeared in c11, I think). I wonder if it would be
> > helpful to teach config.mak.dev to pass -std=c99.
>
> FWIW, I use -std=gnu99 as our Makefile suggests.

I understand that the default build should be lenient rather than strict for portability reasons. However, it would be good if the CI was strict with this.

-- 
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--

Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado