Re: [PATCH v5 02/16] reftable: fix resource leak in block.c error path
On Fri, Dec 24, 2021 at 5:16 AM Junio C Hamano <gitster@pobox.com> wrote:
Show 5 quoted lines
> Once you
> initialize at the declaration with "less meaningful" value (like
> zero initialization), the tools won't be able to tell when the code
> uses that variable "uninitialized" (because the assignment was
> skipped by a bug), since it appears to always be initialied to them.
Which tools are these? When I add
static void test_memcpy(void)
{
uint32_t dest;
char not_init[200];
int i;
memcpy(&dest, not_init, sizeof(dest)); for (i = 0 ; i < 10; i++)
not_init[i] = rand() % 255 + 1;
printf("%d", (int) strlen(not_init));
}to the C code, it compiles cleanly if I do "make DEVELOPER=1".
--
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--
Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
Han-Wen Nienhuys <hanwen@google.com>