Re: [PATCH v5 01/16] reftable: fix OOB stack write in print functions

From: Han-Wen Nienhuys <hanwen@google.com>
Date: Dec 23, 2021, 15:58 UTC
Message-ID: <CAFQ2z_MsQjrucS5XiR7sDWb=sZKu0KFYVBspL_dvyq2DoDufKw@mail.gmail.com>
In-Reply-To: <xmqq8rwcfe36.fsf@gitster.g>

On Wed, Dec 22, 2021 at 11:51 PM Junio C Hamano <gitster@pobox.com> wrote:>

Show 5 quoted lines

> Wow.  The first one is future-proofing in case we learn to use even
> larger hash, but the latter is an outright bug that makes reviewers
> feel embarrassed, isn't it?
>
> Thanks for noticing and fixing it.

You should thank Coverity :-)

-- 
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--

Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.