Re: [PATCH v3 08/11] reftable: order unittests by complexity

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Dec 13, 2021, 16:25 UTC
Message-ID: <211213.86h7bc8o9i.gmgdl@evledraar.gmail.com>
In-Reply-To: <9dce18d7349fe2a27859c224068fb5a386f263f1.1639411309.git.gitgitgadget@gmail.com>

On Mon, Dec 13 2021, Han-Wen Nienhuys via GitGitGadget wrote:

Show 19 quoted lines

> From: Han-Wen Nienhuys <hanwen@google.com>
>
> This is a more pratical ordering when working on refactorings of the reftable
> code.
>
> Signed-off-by: Han-Wen Nienhuys <hanwen@google.com>
> ---
>  t/helper/test-reftable.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/t/helper/test-reftable.c b/t/helper/test-reftable.c
> index 26b03d7b789..f08d66df949 100644
> --- a/t/helper/test-reftable.c
> +++ b/t/helper/test-reftable.c
> @@ -3,15 +3,16 @@
>  
>  int cmd__reftable(int argc, const char **argv)
>  {
> +	// test from simple to complex.

A C99 comment, which I don't mind, but is explicitly forbidden by the style guide (and when I mentioned recently that we didn't have any portability reasons not to use these, there wasn't much/any interest in changing that...).