Re: [PATCH v3 09/11] reftable: drop stray printf in readwrite_test
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Dec 13, 2021, 16:26 UTC
- Message-ID
- <211213.86czm08o8k.gmgdl@evledraar.gmail.com>
- In-Reply-To
- <6b0af68f0b94fb96c81e25f9a1911fa05dcf07fd.1639411309.git.gitgitgadget@gmail.com>
On Mon, Dec 13 2021, Han-Wen Nienhuys via GitGitGadget wrote:
Show 19 quoted lines
> From: Han-Wen Nienhuys <hanwen@google.com>
>
> Signed-off-by: Han-Wen Nienhuys <hanwen@google.com>
> ---
> reftable/readwrite_test.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/reftable/readwrite_test.c b/reftable/readwrite_test.c
> index 42caf0bde4c..f6546d7b8d1 100644
> --- a/reftable/readwrite_test.c
> +++ b/reftable/readwrite_test.c
> @@ -663,7 +663,6 @@ static void test_write_key_order(void)
> err = reftable_writer_add_ref(w, &refs[0]);
> EXPECT_ERR(err);
> err = reftable_writer_add_ref(w, &refs[1]);
> - printf("%d\n", err);
> EXPECT(err == REFTABLE_API_ERROR);
> reftable_writer_close(w);
> reftable_writer_free(w);Is this something coverity raised and I'm missing why it's bad (per the CL), or just a stray unrelated cleanup?