Re: [PATCH 24/26] upload-pack: split check_unreachable() in two, prep for get_reachable_list()

From: Duy Nguyen <pclouds@gmail.com>
Date: Jun 10, 2016, 12:14 UTC
Message-ID: <CACsJy8BTWu-meKQcB8Xqa5bniM1z3LNP6eEJe_mmiuPTD5U9_A@mail.gmail.com>
In-Reply-To: <CAPig+cTyzA1HFt=K14UBPsKhWhHmy0WX8=tru7HQmP3m+GpGgQ@mail.gmail.com>

On Mon, Jun 6, 2016 at 2:43 AM, Eric Sunshine <sunshine@sunshineco.com> wrote:

Show 8 quoted lines

>>         /*
>>          * The commits out of the rev-list are not ancestors of
>>          * our ref.
>>          */
>> -       i = read_in_full(cmd.out, namebuf, 1);
>> +       i = read_in_full(cmd.out, buf, 1);
>
> s/1/sizeof(buf)/ perhaps or does that make the intent less clear?

Yeah I think so. "1" makes it obvious that we do not care about the actual content (or at least raise some eyebrows and force the reader to understand this entire function). sizeof(buf), not so much.

-- 
Duy

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.