git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 19/26] refs: add expand_ref()

From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Date
Apr 13, 2016, 12:55 UTC
Message-ID
<1460552110-5554-20-git-send-email-pclouds@gmail.com>
In-Reply-To
<1460552110-5554-1-git-send-email-pclouds@gmail.com>

This is basically dwim_ref() without @{} support. To be used on the server side where we want to expand abbreviated to full ref names and nothing else. The first user is "git clone/fetch --shallow-exclude".

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 refs.c | 8 +++++++-
 refs.h | 1 +
 2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/refs.c b/refs.c
index e2d34b2..842e4d8 100644
--- a/refs.c
+++ b/refs.c
@@ -392,6 +392,13 @@ static char *substitute_branch_name(const char **string, int *len)
 int dwim_ref(const char *str, int len, unsigned char *sha1, char **ref)
 {
 	char *last_branch = substitute_branch_name(&str, &len);
+	int   refs_found  = expand_ref(str, len, sha1, ref);
+	free(last_branch);
+	return refs_found;
+}
+
+int expand_ref(const char *str, int len, unsigned char *sha1, char **ref)
+{
 	const char **p, *r;
 	int refs_found = 0;
 
@@ -417,7 +424,6 @@ int dwim_ref(const char *str, int len, unsigned char *sha1, char **ref)
 			warning("ignoring broken ref %s.", fullref);
 		}
 	}
-	free(last_branch);
 	return refs_found;
 }
 
diff --git a/refs.h b/refs.h
index 3c3da29..31a2fa6 100644
--- a/refs.h
+++ b/refs.h
@@ -90,6 +90,7 @@ extern int resolve_gitlink_ref(const char *path, const char *refname, unsigned c
  */
 extern int refname_match(const char *abbrev_name, const char *full_name);
 
+extern int expand_ref(const char *str, int len, unsigned char *sha1, char **ref);
 extern int dwim_ref(const char *str, int len, unsigned char *sha1, char **ref);
 extern int dwim_log(const char *str, int len, unsigned char *sha1, char **ref);
 
-- 
2.8.0.rc0.210.gd302cd2
Previous: Eric SunshineNext: Nguyễn Thái Ngọc Duy
Message 26 of 40 in “nd/shallow-deepen updates”
  1. 00/26 nd/shallow-deepen updatesNguyễn Thái Ngọc Duy, Apr 13, 2016
  2. 01/26 remote-curl.c: convert fetch_git() to use argv_arrayNguyễn Thái Ngọc Duy, Apr 13, 2016
  3. Eric SunshineMay 25, 2016
  4. 02/26 transport-helper.c: refactor set_helper_option()Nguyễn Thái Ngọc Duy, Apr 13, 2016
  5. Eric SunshineMay 25, 2016
  6. 03/26 upload-pack: move shallow deepen code out of receive_needs()Nguyễn Thái Ngọc Duy, Apr 13, 2016
  7. 04/26 upload-pack: move "shallow" sending code out of deepen()Nguyễn Thái Ngọc Duy, Apr 13, 2016
  8. 05/26 upload-pack: remove unused variable "backup"Nguyễn Thái Ngọc Duy, Apr 13, 2016
  9. 06/26 upload-pack: move "unshallow" sending code out of deepen()Nguyễn Thái Ngọc Duy, Apr 13, 2016
  10. 07/26 upload-pack: use skip_prefix() instead of starts_with()Nguyễn Thái Ngọc Duy, Apr 13, 2016
  11. Eric SunshineMay 25, 2016
  12. 08/26 upload-pack: tighten number parsing at "deepen" linesNguyễn Thái Ngọc Duy, Apr 13, 2016
  13. 09/26 upload-pack: move rev-list code out of check_non_tip()Nguyễn Thái Ngọc Duy, Apr 13, 2016
  14. Eric SunshineMay 25, 2016
  15. 10/26 fetch-pack: use skip_prefix() instead of starts_with()Nguyễn Thái Ngọc Duy, Apr 13, 2016
  16. 11/26 fetch-pack: use a common function for verbose printingNguyễn Thái Ngọc Duy, Apr 13, 2016
  17. 12/26 fetch-pack.c: mark strings for translatingNguyễn Thái Ngọc Duy, Apr 13, 2016
  18. 13/26 fetch-pack: use a separate flag for fetch in deepening modeNguyễn Thái Ngọc Duy, Apr 13, 2016
  19. 14/26 shallow.c: implement a generic shallow boundary finder based on rev-listNguyễn Thái Ngọc Duy, Apr 13, 2016
  20. Eric SunshineMay 27, 2016
  21. 15/26 upload-pack: add deepen-since to cut shallow repos based on timeNguyễn Thái Ngọc Duy, Apr 13, 2016
  22. 16/26 fetch: define shallow boundary with --shallow-sinceNguyễn Thái Ngọc Duy, Apr 13, 2016
  23. 17/26 clone: define shallow clone boundary based on time with --shallow-sinceNguyễn Thái Ngọc Duy, Apr 13, 2016
  24. 18/26 t5500, t5539: tests for shallow depth since a specific dateNguyễn Thái Ngọc Duy, Apr 13, 2016
  25. Eric SunshineJun 5, 2016
  26. 19/26 refs: add expand_ref()Nguyễn Thái Ngọc Duy, Apr 13, 2016
  27. 20/26 upload-pack: support define shallow boundary by excluding revisionsNguyễn Thái Ngọc Duy, Apr 13, 2016
  28. 21/26 fetch: define shallow boundary with --shallow-excludeNguyễn Thái Ngọc Duy, Apr 13, 2016
  29. Eric SunshineJun 5, 2016
  30. 22/26 clone: define shallow clone boundary with --shallow-excludeNguyễn Thái Ngọc Duy, Apr 13, 2016
  31. Eric SunshineJun 5, 2016
  32. 23/26 t5500, t5539: tests for shallow depth excluding a refNguyễn Thái Ngọc Duy, Apr 13, 2016
  33. Eric SunshineJun 5, 2016
  34. 24/26 upload-pack: split check_unreachable() in two, prep for get_reachable_list()Nguyễn Thái Ngọc Duy, Apr 13, 2016
  35. Eric SunshineJun 5, 2016
  36. Duy NguyenJun 10, 2016
  37. 25/26 upload-pack: add get_reachable_list()Nguyễn Thái Ngọc Duy, Apr 13, 2016
  38. Eric SunshineJun 5, 2016
  39. 26/26 fetch, upload-pack: --deepen=N extends shallow boundary by N commitsNguyễn Thái Ngọc Duy, Apr 13, 2016
  40. Junio C HamanoApr 14, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.