git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 05/26] upload-pack: remove unused variable "backup"

From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Date
Apr 13, 2016, 12:54 UTC
Message-ID
<1460552110-5554-6-git-send-email-pclouds@gmail.com>
In-Reply-To
<1460552110-5554-1-git-send-email-pclouds@gmail.com>

After the last patch, "result" and "backup" are the same. "result" used to move, but the movement is now contained in send_shallow(). Delete this redundant variable.

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 upload-pack.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/upload-pack.c b/upload-pack.c
index 0eb9a0b..ee5d20b 100644
--- a/upload-pack.c
+++ b/upload-pack.c
@@ -554,7 +554,7 @@ static void send_shallow(struct commit_list *result)
 
 static void deepen(int depth, const struct object_array *shallows)
 {
-	struct commit_list *result = NULL, *backup = NULL;
+	struct commit_list *result = NULL;
 	int i;
 	if (depth == INFINITE_DEPTH && !is_repository_shallow())
 		for (i = 0; i < shallows->nr; i++) {
@@ -562,11 +562,10 @@ static void deepen(int depth, const struct object_array *shallows)
 			object->flags |= NOT_SHALLOW;
 		}
 	else
-		backup = result =
-			get_shallow_commits(&want_obj, depth,
-					    SHALLOW, NOT_SHALLOW);
+		result = get_shallow_commits(&want_obj, depth,
+					     SHALLOW, NOT_SHALLOW);
 	send_shallow(result);
-	free_commit_list(backup);
+	free_commit_list(result);
 	for (i = 0; i < shallows->nr; i++) {
 		struct object *object = shallows->objects[i].item;
 		if (object->flags & NOT_SHALLOW) {
-- 
2.8.0.rc0.210.gd302cd2
Previous: Nguyễn Thái Ngọc DuyNext: Nguyễn Thái Ngọc Duy
Message 8 of 40 in “nd/shallow-deepen updates”
  1. 00/26 nd/shallow-deepen updatesNguyễn Thái Ngọc Duy, Apr 13, 2016
  2. 01/26 remote-curl.c: convert fetch_git() to use argv_arrayNguyễn Thái Ngọc Duy, Apr 13, 2016
  3. Eric SunshineMay 25, 2016
  4. 02/26 transport-helper.c: refactor set_helper_option()Nguyễn Thái Ngọc Duy, Apr 13, 2016
  5. Eric SunshineMay 25, 2016
  6. 03/26 upload-pack: move shallow deepen code out of receive_needs()Nguyễn Thái Ngọc Duy, Apr 13, 2016
  7. 04/26 upload-pack: move "shallow" sending code out of deepen()Nguyễn Thái Ngọc Duy, Apr 13, 2016
  8. 05/26 upload-pack: remove unused variable "backup"Nguyễn Thái Ngọc Duy, Apr 13, 2016
  9. 06/26 upload-pack: move "unshallow" sending code out of deepen()Nguyễn Thái Ngọc Duy, Apr 13, 2016
  10. 07/26 upload-pack: use skip_prefix() instead of starts_with()Nguyễn Thái Ngọc Duy, Apr 13, 2016
  11. Eric SunshineMay 25, 2016
  12. 08/26 upload-pack: tighten number parsing at "deepen" linesNguyễn Thái Ngọc Duy, Apr 13, 2016
  13. 09/26 upload-pack: move rev-list code out of check_non_tip()Nguyễn Thái Ngọc Duy, Apr 13, 2016
  14. Eric SunshineMay 25, 2016
  15. 10/26 fetch-pack: use skip_prefix() instead of starts_with()Nguyễn Thái Ngọc Duy, Apr 13, 2016
  16. 11/26 fetch-pack: use a common function for verbose printingNguyễn Thái Ngọc Duy, Apr 13, 2016
  17. 12/26 fetch-pack.c: mark strings for translatingNguyễn Thái Ngọc Duy, Apr 13, 2016
  18. 13/26 fetch-pack: use a separate flag for fetch in deepening modeNguyễn Thái Ngọc Duy, Apr 13, 2016
  19. 14/26 shallow.c: implement a generic shallow boundary finder based on rev-listNguyễn Thái Ngọc Duy, Apr 13, 2016
  20. Eric SunshineMay 27, 2016
  21. 15/26 upload-pack: add deepen-since to cut shallow repos based on timeNguyễn Thái Ngọc Duy, Apr 13, 2016
  22. 16/26 fetch: define shallow boundary with --shallow-sinceNguyễn Thái Ngọc Duy, Apr 13, 2016
  23. 17/26 clone: define shallow clone boundary based on time with --shallow-sinceNguyễn Thái Ngọc Duy, Apr 13, 2016
  24. 18/26 t5500, t5539: tests for shallow depth since a specific dateNguyễn Thái Ngọc Duy, Apr 13, 2016
  25. Eric SunshineJun 5, 2016
  26. 19/26 refs: add expand_ref()Nguyễn Thái Ngọc Duy, Apr 13, 2016
  27. 20/26 upload-pack: support define shallow boundary by excluding revisionsNguyễn Thái Ngọc Duy, Apr 13, 2016
  28. 21/26 fetch: define shallow boundary with --shallow-excludeNguyễn Thái Ngọc Duy, Apr 13, 2016
  29. Eric SunshineJun 5, 2016
  30. 22/26 clone: define shallow clone boundary with --shallow-excludeNguyễn Thái Ngọc Duy, Apr 13, 2016
  31. Eric SunshineJun 5, 2016
  32. 23/26 t5500, t5539: tests for shallow depth excluding a refNguyễn Thái Ngọc Duy, Apr 13, 2016
  33. Eric SunshineJun 5, 2016
  34. 24/26 upload-pack: split check_unreachable() in two, prep for get_reachable_list()Nguyễn Thái Ngọc Duy, Apr 13, 2016
  35. Eric SunshineJun 5, 2016
  36. Duy NguyenJun 10, 2016
  37. 25/26 upload-pack: add get_reachable_list()Nguyễn Thái Ngọc Duy, Apr 13, 2016
  38. Eric SunshineJun 5, 2016
  39. 26/26 fetch, upload-pack: --deepen=N extends shallow boundary by N commitsNguyễn Thái Ngọc Duy, Apr 13, 2016
  40. Junio C HamanoApr 14, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.