git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 25/26] upload-pack: add get_reachable_list()

From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Date
Apr 13, 2016, 12:55 UTC
Message-ID
<1460552110-5554-26-git-send-email-pclouds@gmail.com>
In-Reply-To
<1460552110-5554-1-git-send-email-pclouds@gmail.com>
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 object.h      |  2 +-
 upload-pack.c | 52 +++++++++++++++++++++++++++++++++++++++++++++++++---
 2 files changed, 50 insertions(+), 4 deletions(-)
diff --git a/object.h b/object.h
index f8b6442..614a006 100644
--- a/object.h
+++ b/object.h
@@ -31,7 +31,7 @@ struct object_array {
  * revision.h:      0---------10                                26
  * fetch-pack.c:    0---4
  * walker.c:        0-2
- * upload-pack.c:               11----------------19
+ * upload-pack.c:       4       11----------------19
  * builtin/blame.c:               12-13
  * bisect.c:                               16
  * bundle.c:                               16
diff --git a/upload-pack.c b/upload-pack.c
index 9e4a4fa..9bd590c 100644
--- a/upload-pack.c
+++ b/upload-pack.c
@@ -453,7 +453,8 @@ static int is_our_ref(struct object *o)
 }
 
 static int do_reachable_revlist(struct child_process *cmd,
-				struct object_array *src)
+				struct object_array *src,
+				struct object_array *reachable)
 {
 	static const char *argv[] = {
 		"rev-list", "--stdin", NULL,
@@ -484,6 +485,8 @@ static int do_reachable_revlist(struct child_process *cmd,
 		o = get_indexed_object(--i);
 		if (!o)
 			continue;
+		if (reachable && o->type == OBJ_COMMIT)
+			o->flags &= ~TMP_MARK;
 		if (!is_our_ref(o))
 			continue;
 		memcpy(namebuf + 1, oid_to_hex(&o->oid), GIT_SHA1_HEXSZ);
@@ -493,8 +496,13 @@ static int do_reachable_revlist(struct child_process *cmd,
 	namebuf[40] = '\n';
 	for (i = 0; i < src->nr; i++) {
 		o = src->objects[i].item;
-		if (is_our_ref(o))
+		if (is_our_ref(o)) {
+			if (reachable)
+				add_object_array(o, NULL, reachable);
 			continue;
+		}
+		if (reachable && o->type == OBJ_COMMIT)
+			o->flags |= TMP_MARK;
 		memcpy(namebuf, oid_to_hex(&o->oid), GIT_SHA1_HEXSZ);
 		if (write_in_full(cmd->in, namebuf, 41) < 0)
 			return -1;
@@ -505,10 +513,48 @@ static int do_reachable_revlist(struct child_process *cmd,
 	return 0;
 }
 
+static int get_reachable_list(struct object_array *src,
+			      struct object_array *reachable)
+{
+	struct child_process cmd = CHILD_PROCESS_INIT;
+	int i, ret = do_reachable_revlist(&cmd, src, reachable);
+	struct object *o;
+	char namebuf[42]; /* ^ + SHA-1 + LF */
+
+	if (ret < 0)
+		return -1;
+
+	while ((i = read_in_full(cmd.out, namebuf, 41)) == 41) {
+		struct object_id sha1;
+
+		if (namebuf[40] != '\n' || get_oid_hex(namebuf, &sha1))
+			break;
+
+		o = lookup_object(sha1.hash);
+		if (o && o->type == OBJ_COMMIT) {
+			o->flags &= ~TMP_MARK;
+		}
+	}
+	for (i = get_max_object_index(); 0 < i; i--) {
+		o = get_indexed_object(i - 1);
+		if (o && o->type == OBJ_COMMIT &&
+		    (o->flags & TMP_MARK)) {
+			add_object_array(o, NULL, reachable);
+				o->flags &= ~TMP_MARK;
+		}
+	}
+	close(cmd.out);
+
+	if (finish_command(&cmd))
+		return -1;
+
+	return 0;
+}
+
 static int check_unreachable(struct object_array *src)
 {
 	struct child_process cmd = CHILD_PROCESS_INIT;
-	int i, ret = do_reachable_revlist(&cmd, src);
+	int i, ret = do_reachable_revlist(&cmd, src, NULL);
 	char buf[1];
 
 	if (ret < 0)
-- 
2.8.0.rc0.210.gd302cd2
Previous: Duy NguyenNext: Eric Sunshine
Message 37 of 40 in “nd/shallow-deepen updates”
  1. 00/26 nd/shallow-deepen updatesNguyễn Thái Ngọc Duy, Apr 13, 2016
  2. 01/26 remote-curl.c: convert fetch_git() to use argv_arrayNguyễn Thái Ngọc Duy, Apr 13, 2016
  3. Eric SunshineMay 25, 2016
  4. 02/26 transport-helper.c: refactor set_helper_option()Nguyễn Thái Ngọc Duy, Apr 13, 2016
  5. Eric SunshineMay 25, 2016
  6. 03/26 upload-pack: move shallow deepen code out of receive_needs()Nguyễn Thái Ngọc Duy, Apr 13, 2016
  7. 04/26 upload-pack: move "shallow" sending code out of deepen()Nguyễn Thái Ngọc Duy, Apr 13, 2016
  8. 05/26 upload-pack: remove unused variable "backup"Nguyễn Thái Ngọc Duy, Apr 13, 2016
  9. 06/26 upload-pack: move "unshallow" sending code out of deepen()Nguyễn Thái Ngọc Duy, Apr 13, 2016
  10. 07/26 upload-pack: use skip_prefix() instead of starts_with()Nguyễn Thái Ngọc Duy, Apr 13, 2016
  11. Eric SunshineMay 25, 2016
  12. 08/26 upload-pack: tighten number parsing at "deepen" linesNguyễn Thái Ngọc Duy, Apr 13, 2016
  13. 09/26 upload-pack: move rev-list code out of check_non_tip()Nguyễn Thái Ngọc Duy, Apr 13, 2016
  14. Eric SunshineMay 25, 2016
  15. 10/26 fetch-pack: use skip_prefix() instead of starts_with()Nguyễn Thái Ngọc Duy, Apr 13, 2016
  16. 11/26 fetch-pack: use a common function for verbose printingNguyễn Thái Ngọc Duy, Apr 13, 2016
  17. 12/26 fetch-pack.c: mark strings for translatingNguyễn Thái Ngọc Duy, Apr 13, 2016
  18. 13/26 fetch-pack: use a separate flag for fetch in deepening modeNguyễn Thái Ngọc Duy, Apr 13, 2016
  19. 14/26 shallow.c: implement a generic shallow boundary finder based on rev-listNguyễn Thái Ngọc Duy, Apr 13, 2016
  20. Eric SunshineMay 27, 2016
  21. 15/26 upload-pack: add deepen-since to cut shallow repos based on timeNguyễn Thái Ngọc Duy, Apr 13, 2016
  22. 16/26 fetch: define shallow boundary with --shallow-sinceNguyễn Thái Ngọc Duy, Apr 13, 2016
  23. 17/26 clone: define shallow clone boundary based on time with --shallow-sinceNguyễn Thái Ngọc Duy, Apr 13, 2016
  24. 18/26 t5500, t5539: tests for shallow depth since a specific dateNguyễn Thái Ngọc Duy, Apr 13, 2016
  25. Eric SunshineJun 5, 2016
  26. 19/26 refs: add expand_ref()Nguyễn Thái Ngọc Duy, Apr 13, 2016
  27. 20/26 upload-pack: support define shallow boundary by excluding revisionsNguyễn Thái Ngọc Duy, Apr 13, 2016
  28. 21/26 fetch: define shallow boundary with --shallow-excludeNguyễn Thái Ngọc Duy, Apr 13, 2016
  29. Eric SunshineJun 5, 2016
  30. 22/26 clone: define shallow clone boundary with --shallow-excludeNguyễn Thái Ngọc Duy, Apr 13, 2016
  31. Eric SunshineJun 5, 2016
  32. 23/26 t5500, t5539: tests for shallow depth excluding a refNguyễn Thái Ngọc Duy, Apr 13, 2016
  33. Eric SunshineJun 5, 2016
  34. 24/26 upload-pack: split check_unreachable() in two, prep for get_reachable_list()Nguyễn Thái Ngọc Duy, Apr 13, 2016
  35. Eric SunshineJun 5, 2016
  36. Duy NguyenJun 10, 2016
  37. 25/26 upload-pack: add get_reachable_list()Nguyễn Thái Ngọc Duy, Apr 13, 2016
  38. Eric SunshineJun 5, 2016
  39. 26/26 fetch, upload-pack: --deepen=N extends shallow boundary by N commitsNguyễn Thái Ngọc Duy, Apr 13, 2016
  40. Junio C HamanoApr 14, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.