Re: [PATCH v2 27/27] fsmonitor-ll.h: split this header out of fsmonitor.h

From: Elijah Newren <newren@gmail.com>
Date: May 16, 2023, 03:07 UTC
Message-ID: <CABPp-BHFA4LhY0pxv2jqc5tcUD-jF=_aLx8oFD-2+sa8hxsg7A@mail.gmail.com>
In-Reply-To: <20230516001707.1460816-1-jonathantanmy@google.com>

On Mon, May 15, 2023 at 5:17 PM Jonathan Tan <jonathantanmy@google.com> wrote:

Show 16 quoted lines

>
> "Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com> writes:
> > From: Elijah Newren <newren@gmail.com>
> >
> > This creates a new fsmonitor-ll.h with most of the functions from
> > fsmonitor.h, though it leaves three inline functions where they were.
> > Two-thirds of the files that previously included fsmonitor.h did not
> > need those three inline functions or the six extra includes those inline
> > functions required, so this allows them to only include the lower level
> > header.
> >
> > Diff best viewed with `--color-moved`.
> >
> > Signed-off-by: Elijah Newren <newren@gmail.com>
>
> Looks good. Thanks for this significant effort.

Thanks for the review!