Re: [PATCH v2 05/27] read-cache: move shared commit and ls-files code

From: Jonathan Tan <jonathantanmy@google.com>
Date: May 12, 2023, 21:25 UTC
Message-ID: <20230512212507.1125662-1-jonathantanmy@google.com>
In-Reply-To: <ced75f464447f77fc8d89b5cc97477352f6bfd02.1683875070.git.gitgitgadget@gmail.com>

"Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com> writes:

> -void overlay_tree_on_index(struct index_state *istate,
> -			   const char *tree_name, const char *prefix)

 
Thanks for moving the code in such a way that it's easy to see with
--color-moved. I saw that there was no corresponding .h change (unlike
the parent), but this function is declared in cache.h, so that makes
sense. (I think this will be dealt later on in this series anyway.)

Up to here looks good.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.