Re: [PATCH v2 17/27] cache.h: remove this no-longer-used header

From: Elijah Newren <newren@gmail.com>
Date: May 16, 2023, 03:02 UTC
Message-ID: <CABPp-BH-cmCm4CGrCpyPXCYhQtJSab5hPD7Y8GOB5jW3ngxqCg@mail.gmail.com>
In-Reply-To: <20230516000241.1459276-1-jonathantanmy@google.com>

On Mon, May 15, 2023 at 5:02 PM Jonathan Tan <jonathantanmy@google.com> wrote:

Show 21 quoted lines

>
> "Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com> writes:
> > From: Elijah Newren <newren@gmail.com>
> >
> > Since this header showed up in some places besides just #include
> > statements, update/clean-up/remove those other places as well.
> >
> > Note that compat/fsmonitor/fsm-path-utils-darwin.c previously got
> > away with violating the rule that all files must start with an include
> > of git-compat-util.h (or a short-list of alternate headers that happen
> > to include it first).  This change exposed the violation and caused it
> > to stop building correctly; fix it by having it include
> > git-compat-util.h first, as per policy.
> >
> > Signed-off-by: Elijah Newren <newren@gmail.com>
>
> Ah, a monumental effort indeed (to finally remove cache.h). This patch
> was one of a few called out in the cover letter [1] as needing reviewer
> focus, but this patch seemed straightforward to me (changing the text
> wherever cache.h is mentioned in relatively obvious ways) so hopefully
> I'm not missing anything.

I mostly called it out simply because this patch was different than all the other ones, due to the Makefile and Documentation changes. I figured that those who wanted to "spot check" deserved an easy way to find the different kinds of changes involved.

Although, I was a bit curious after the patch what the purpose of the SHA1DC_CUSTOM_INCLUDE_SHA1_C and SHA1DC_CUSTOM_INCLUDE_UBC_CHECK_C defines were and why there were two different ones. I tried to do a little history spelunking to find out, but it didn't shed any light on the issue for me. Setting them both to git-compat-util.h works just fine, so...*shrug*.