Re: [PATCH v2 03/27] init-db, clone: change unnecessary global into passed parameter

From: Jonathan Tan <jonathantanmy@google.com>
Date: May 12, 2023, 21:28 UTC
Message-ID: <20230512212822.1126697-1-jonathantanmy@google.com>
In-Reply-To: <3bc4dfeea901d9e57cee41666f85c783026d7e82.1683875070.git.gitgitgadget@gmail.com>

"Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: Elijah Newren <newren@gmail.com>
> 
> Much like the former commit, this commit was prompted by a desire to

Could we have s/former/parent? I'm not used to "former" with this meaning (but if it's understood by others, then that's fine).

Show 9 quoted lines

> diff --git a/builtin/clone.c b/builtin/clone.c
> index 15f9912b4ca..cc34c194f5e 100644
> --- a/builtin/clone.c
> +++ b/builtin/clone.c
> @@ -930,6 +930,7 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
>  	int submodule_progress;
>  	int filter_submodules = 0;
>  	int hash_algo;
> +	const int do_not_override_repo_unix_permissions = -1;

I don't really like this name, but init_db() is undocumented so an anonymous -1 at the call site is not much better. For the purposes of this patch set (getting rid of cache.h), this should be fine for now.