From: Jacob Keller <jacob.keller@gmail.com>
Date: Thu, 31 Mar 2016 00:32:16 GMT
Subject: Re: [PATCH 2/4] submodule--helper clone: simplify path check
Message-ID: <CA+P7+xq0w+dyhpT7VeURjj5wEa6++p_N2ASLYzjeQy+eOgLQLQ@mail.gmail.com>
In-Reply-To: <1459383457-6848-3-git-send-email-sbeller@google.com>

On Wed, Mar 30, 2016 at 5:17 PM, Stefan Beller <sbeller@google.com> wrote:
> The calling shell code makes sure that `path` is non null and non empty.
> (side note: it cannot be null as just three lines before it is passed
> to safe_create_leading_directories_const which would crash as you feed
> it null).
>

So we're going to assume that all callers of submodule--helper will
provide a non-null non-empty path? Hmm, since we expect only our shell
code to really do this... that's probably ok I think. I don't think it
can do any real harm should someone outside git call it with a bad
path.

Thanks,
Jake