git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC] autoconf: Add test for OLD_ICONV

From
Wincent Colaiuta <win@wincent.com>
Date
Dec 6, 2007, 19:07 UTC
Message-ID
<BCD45527-C564-4CD3-9797-36F6251377E6@wincent.com>
In-Reply-To
<200712052219.00930.jnareb@gmail.com>
El 5/12/2007, a las 22:19, Jakub Narebski escribió:
> Ahhh... now I understand. You have installed new iconv() on your
> computer, and generic 'uname -s' (OS name) based guessing in Makefile
> guesses wrongly that you need OLD_ICONV, while ./configure script
> actually tests it and correctly decides to unset OLD_ICONV !

No, nothing installed. It's that Mac OS X 10.5 (Leopard)/Darwin 9 comes with a newer version of iconv. So while there was no warning prior to Leopard there is one now, which your patch fixes for those using configure.

This came up before here:
<http://marc.info/?l=git&m=119397507006026&w=2>

Still, I'd like to fix the warning for those who don't use configure. Have posted a separate patch for that just now.

Cheers,
>
Wincent
Previous: Brian GernhardtNext: Junio C Hamano
Message 14 of 20 in “autoconf: Add tests for memmem, strtoumax and mkdtemp functions”
  1. autoconf: Add tests for memmem, strtoumax and mkdtemp functionsJakub Narebski, Nov 19, 2007
  2. Shawn O. PearceNov 21, 2007
  3. Jakub NarebskiNov 21, 2007
  4. Stefan-W. HahnNov 20, 2007
  5. Matt KraaiNov 21, 2007
  6. autoconf: Add test for OLD_ICONVJakub Narebski, Dec 5, 2007
  7. Brian GernhardtDec 5, 2007
  8. Jakub NarebskiDec 5, 2007
  9. Wincent ColaiutaDec 5, 2007
  10. Jakub NarebskiDec 5, 2007
  11. Wincent ColaiutaDec 5, 2007
  12. Jakub NarebskiDec 5, 2007
  13. Brian GernhardtDec 5, 2007
  14. Wincent ColaiutaDec 6, 2007
  15. Junio C HamanoDec 5, 2007
  16. Jakub NarebskiDec 5, 2007
  17. Junio C HamanoDec 5, 2007
  18. autoconf: Add test for OLD_ICONV (squelching compiler warning)Jakub Narebski, Dec 5, 2007
  19. Junio C HamanoDec 5, 2007
  20. Pascal ObryDec 5, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.